RFE-9579: Add support for resources in FileIntegrity - #999
RFE-9579: Add support for resources in FileIntegrity#999eloy-valderacarrasco wants to merge 4 commits into
Conversation
|
Hi @eloy-valderacarrasco. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@eloy-valderacarrasco: This pull request references RFE-9579 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eloy-valderacarrasco The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add configurable resources for the AIDE daemon (
spec.resources)Adds an optional
spec.resourcesfield to theFileIntegrityCR so you can set CPU/memory requests and limits for the AIDE daemon pods.Why?
The AIDE daemon's memory and CPU usage scales with the size of the filesystem it scans. On large clusters — nodes with many files, a large
/, or dense workloads — the fixed default limits are too low: the daemon gets OOMKilled or CPU-throttled, so integrity scans slow down, fail, or never complete, leaving nodes without reliable file-integrity monitoring.Right now there's no way to raise these limits. Making resources configurable lets cluster admins right-size the daemon per environment — increasing limits on large/busy clusters, or tightening them on small ones — instead of being stuck with one-size-fits-all values.
What changed
API:
resourcesfield to the top-levelFileIntegrityspec (spec.resources)+kubebuilder:defaultmarker (requests: 40Mi/40m, limits: 600Mi/300m)Controller:
spec.resourcesto the AIDE daemon container at DaemonSet create timeTests:
TestFileIntegrityChangeResources)Docs:
resourcesfieldExample