Add PR bundle image - #792
Conversation
71b30cf to
c742bc2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
e54255c to
a472d52
Compare
|
This is very interesting @Vincent056 |
| name: CHAINS-GIT_COMMIT | ||
| value: $(tasks.clone-repository.results.commit) | ||
| tasks: | ||
| - name: wait-for-operator-image |
There was a problem hiding this comment.
@Vincent056 I'm starting to think that we need to have a separate pipeline that builds the Bundle image from the PR changes.
I say this because ideally we should be building the images only when relevant changes to each image is made:
- We only build the operator image when changes for the operator code are made
- We should only build the bundle image when relevant changes for the bundle are made.
There will be cases when we may only need or want to build the bundle image. In this case there is no operator image build to wait for.
There was a problem hiding this comment.
I think bundle should always be built as long as we have triggered operator build in a PR.
There was a problem hiding this comment.
Yes, that is why we need to have this changed in the operator image pipeliene.
The bundle pipeline may not always have an operator image to wait for if only the bundle image was triggered.
A bundle build should not require an operator build to happen as well.
|
@Vincent056 I have tried a different but similar approach in 89b3f9a Edit: totally wrong link. |
openshift-merge-robot
added
the
needs-rebase
This commit introduces a new task to the Tekton pipeline that waits for the operator image to become available. The task includes parameters for the operator image, maximum wait time, and check interval, along with a script to handle the waiting logic. The init task is updated to run after this new task, ensuring proper sequencing in the pipeline.
a472d52 to
2aa7a67
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
4 participants
This commit introduces a new task to the Tekton pipeline that waits for the operator image to become available. The task includes parameters for the operator image, maximum wait time, and check interval, along with a script to handle the waiting logic. The init task is updated to run after this new task, ensuring proper sequencing in the pipeline.