Skip to content

Fix e2e-aws metrics-test PodSecurity violations and flake cascade - #1006

Open
vickeybrown wants to merge 1 commit into
openshift:masterfrom
vickeybrown:oc-run-override
Open

Fix e2e-aws metrics-test PodSecurity violations and flake cascade#1006
vickeybrown wants to merge 1 commit into
openshift:masterfrom
vickeybrown:oc-run-override

Conversation

@vickeybrown

Copy link
Copy Markdown

Summary

Supersedes #1005 — includes all of @parametalol's changes plus one additional fix:

  • Retry logic for runOCandGetOutput — ephemeral metrics pods routinely hit curl exit 7 (connection refused) while the metrics service is coming up; retries with wait.PollImmediate instead of failing on the first attempt (from Fix e2e-aws flake cascade and metrics-pod connection race #1005)
  • Replace stale cluster-scoped resourcesInitializeClusterResources now deletes and recreates cluster-scoped RBAC objects left behind by a previous test whose cleanup was skipped, instead of hard-failing on "already exists" (from Fix e2e-aws flake cascade and metrics-pod connection race #1005)
  • Add PodSecurity restricted:latest security context to metrics-test pods — all four oc run call sites now include --overrides setting runAsNonRoot, seccompProfile, allowPrivilegeEscalation=false, and capabilities.drop=["ALL"] so the ephemeral pods comply with enforced PodSecurity policy

Test plan

  • go build ./tests/...
  • go vet ./tests/...
  • e2e-aws Prow job passes

Co-Authored-By: Michaël github@parameta.lol

🤖 Generated with Claude Code

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vickeybrown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026
@abushkin-redhat

Copy link
Copy Markdown

/test e2e-aws

@vickeybrown vickeybrown reopened this Jul 30, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@vickeybrown: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index-file-integrity-operator-bundle 0cfec4f link true /test ci-index-file-integrity-operator-bundle
ci/prow/verify 0cfec4f link true /test verify
ci/prow/unit 0cfec4f link true /test unit
ci/prow/e2e-aws 0cfec4f link true /test e2e-aws
ci/prow/images 0cfec4f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants