fix(syslog): remove abort operator from infallible to_string calls in VRL

[vparfonov]

Description

Remove unnecessary ! (abort operator) from to_string!() calls in syslog facility/severity VRL code, no behavior change - only eliminates noisy warnings in collector logs

/cc @Clee2691
/assign @xperimental

Links

• Depending on PR(s):
• GitHub issue:
• JIRA: https://redhat.atlassian.net/browse/LOG-9564
• Enhancement proposal:

Summary by CodeRabbit

• Bug Fixes
  • Improved syslog parsing warnings so invalid facility and severity values are logged more reliably.
  • Prevented logging from failing when converting malformed syslog codes or values.
  • Added clearer warning messages for invalid facility/severity inputs across syslog configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 10d0c06b-5b5b-4281-95df-27604c16217e

📥 Commits

Reviewing files that changed from the base of the PR and between 9d8f84b and 14d14ba.

📒 Files selected for processing (7)

• internal/generator/vector/output/syslog/rfc3164_with_defaults.toml
• internal/generator/vector/output/syslog/syslog.go
• internal/generator/vector/output/syslog/tcp_with_defaults.toml
• internal/generator/vector/output/syslog/tcp_with_kubernetes_minimal_enrichment.toml
• internal/generator/vector/output/syslog/tcp_with_tuning.toml
• internal/generator/vector/output/syslog/tls_with_field_references.toml
• internal/generator/vector/output/syslog/udp_with_every_setting.toml

👮 Files not reviewed due to content moderation or server errors (7)

• internal/generator/vector/output/syslog/tcp_with_kubernetes_minimal_enrichment.toml
• internal/generator/vector/output/syslog/syslog.go
• internal/generator/vector/output/syslog/rfc3164_with_defaults.toml
• internal/generator/vector/output/syslog/tcp_with_tuning.toml
• internal/generator/vector/output/syslog/udp_with_every_setting.toml
• internal/generator/vector/output/syslog/tls_with_field_references.toml
• internal/generator/vector/output/syslog/tcp_with_defaults.toml

---

📝 Walkthrough

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: removing abort operators from syslog VRL to_string calls.
Description check	✅ Passed	The description includes the required Description and Links sections, plus the mandatory /cc and /assign commands and a JIRA link.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[vparfonov]

/assign @jcantrill

[vparfonov]

/retest

[vparfonov]

/retest-required

[jcantrill]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vparfonov]

/retest-required

[openshift-ci]

@vparfonov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-using-bundle	14d14ba	link	false	/test e2e-using-bundle
ci/prow/functional-target	14d14ba	link	true	/test functional-target

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.