UPSTREAM-SYNC: Sync main with latest upstream (release-1.36)#393
Open
stephenfin wants to merge 11 commits into
Open
UPSTREAM-SYNC: Sync main with latest upstream (release-1.36)#393stephenfin wants to merge 11 commits into
stephenfin wants to merge 11 commits into
Conversation
The bumped k8s.io/utils deprecates the slices lib so we switch to the stdlib variant. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
…#3072) * fix(loadbalancer): Added SG delete to ealry return if lb does not exist * chore(loadbalancers): Remove log for early return * fix(loadbalancer): Increase delete timeout by tweaking steps
) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.38.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.38.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I don't work with OpenStack or cloud providers anymore and you can clearly see that my involvement with the project is almost non-existent. This commit removes me from approvers and reviewers of the project.
Tagged releases are no longer allowed in kubernetes/cloud-provider-openstack and all actions must be pinned to a full-length commit SHA.
Bumps [github.com/moby/spdystream](https://github.com/moby/spdystream) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/moby/spdystream/releases) - [Commits](moby/spdystream@v0.5.0...v0.5.1) --- updated-dependencies: - dependency-name: github.com/moby/spdystream dependency-version: 0.5.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix non-constant format string in Eventf call Use Event instead of Eventf since the message is already pre-formatted by fmt.Sprintf and no format arguments are passed. This causes build failures under go 1.26. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Bump go version We need go 1.26.x for the latest k8s. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Update k8s.io/kubernetes to 1.36.0 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Bump gophercloud to v2.12.0 Also bump github.com/gophercloud/utils/v2 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Bump all other dependencies Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Release 1.36.0 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> --------- Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Minimal diff, as expected.
❯ git diff upstream/release-1.36 -- \
':!vendor' ':!DOWNSTREAM_OWNERS' ':!DOWNSTREAM_OWNERS_ALIASES' \
':!.ci-operator.yaml' ':!.snyk' ':!images'
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
openshift-ci-robot
added
jira/valid-reference
|
@stephenfin: This pull request is an upstream sync and explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughBump to v1.36.0: Go/toolchain and module upgrades, Dockerfile and image base updates, Helm charts and manifest image tags bumped, workflows pinned to commit SHAs, OWNERS adjusted, docs/examples updated, and small code and timeout changes. Changesv1.36.0 Release Upgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
images/cinder-csi-plugin/Dockerfile (1)
6-6: 💤 Low valueConsider updating the runtime base image to match the builder version.
The builder image has been updated to OpenShift 4.23, but the runtime image remains at
ocp/4.22:base-rhel9. Consider whether the runtime should also be updated to 4.23 for consistency, unless the 4.22 base is intentionally maintained for compatibility.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@images/cinder-csi-plugin/Dockerfile` at line 6, The Dockerfile currently uses FROM registry.ci.openshift.org/ocp/4.22:base-rhel9 which mismatches the builder image (updated to OpenShift 4.23); update the runtime base image to FROM registry.ci.openshift.org/ocp/4.23:base-rhel9 to match the builder (or add a clear comment explaining why 4.22 is intentionally required for compatibility) so the runtime and builder versions are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 26-27: Update the pinned module versions in go.mod: replace
google.golang.org/grpc v1.80.0 with google.golang.org/grpc v1.81.1 and replace
the pseudo-version google.golang.org/protobuf v1.36.12-0... with the stable
release google.golang.org/protobuf v1.36.11; after editing the module lines for
the modules named google.golang.org/grpc and google.golang.org/protobuf run go
get google.golang.org/grpc@v1.81.1 google.golang.org/protobuf@v1.36.11 and then
go mod tidy to update go.sum and vendor files accordingly.
In `@hack/release-image-digests.sh`:
- Line 18: The example in hack/release-image-digests.sh uses bracketed tags
("[v1.36.0] [v1.35.0]") which will be copied verbatim and break digest
resolution; update the example comment line (the usage/sample line that
currently shows registry.k8s.io/images/k8s-staging-provider-os/images.yaml
[v1.36.0] [v1.35.0]) to use plain tags without brackets (e.g., v1.36.0 v1.35.0)
so copied values are valid image tags.
In `@images/cinder-csi-plugin/Dockerfile`:
- Line 1: The Dockerfile's builder image is rhel-9-golang-1.26-openshift-4.23
but the runtime base image still targets ocp/4.22:base-rhel9; update the runtime
FROM reference to ocp/4.23:base-rhel9 to match the builder (or if the mismatch
is intentional, add a clear comment in the Dockerfile explaining why
ocp/4.22:base-rhel9 is required). Locate the FROM lines (the builder line with
rhel-9-golang-1.26-openshift-4.23 and the runtime line referencing
ocp/4.22:base-rhel9) and make the change or add the explanatory comment to
ensure version consistency or documented intent.
---
Nitpick comments:
In `@images/cinder-csi-plugin/Dockerfile`:
- Line 6: The Dockerfile currently uses FROM
registry.ci.openshift.org/ocp/4.22:base-rhel9 which mismatches the builder image
(updated to OpenShift 4.23); update the runtime base image to FROM
registry.ci.openshift.org/ocp/4.23:base-rhel9 to match the builder (or add a
clear comment explaining why 4.22 is intentionally required for compatibility)
so the runtime and builder versions are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f804d926-f24d-4ca2-9ec2-fa486c101be3
⛔ Files ignored due to path filters (270)
go.sumis excluded by!**/*.sumvendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**,!vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**,!vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/handle_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/root_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/armon/circbuf/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/armon/circbuf/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/armon/circbuf/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/armon/circbuf/circbuf.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/container-storage-interface/spec/lib/go/csi/csi.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/container-storage-interface/spec/lib/go/csi/csi_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/containerd/containerd/api/types/mount.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/containerd/containerd/api/types/mount.protois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/sdnotify_other.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/sdnotify_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/watchdog.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/dbus/dbus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/dbus/methods.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/dbus/set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/dbus/subscription.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/dbus/subscription_set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/coreos/go-systemd/v22/journal/journal_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/VERSIONis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_atomic_go119.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_atomic_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/.cirrus.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/CONTRIBUTING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/backend_fen.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/backend_inotify.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/backend_kqueue.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/backend_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/fsnotify.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/darwin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_darwin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_dragonfly.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_freebsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_kqueue.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_netbsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/debug_openbsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/freebsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/unix2.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/fsnotify/fsnotify/internal/windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/.editorconfigis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/.envrcis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/devenv.lockis excluded by!**/*.lock,!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/devenv.nixis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/devenv.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/flake.lockis excluded by!**/*.lock,!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/flake.nixis excluded by!**/vendor/**,!vendor/**vendor/github.com/go-viper/mapstructure/v2/mapstructure.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/.cirrus.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/auth_default_other.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/auth_default_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/auth_sha1_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/call.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/conn.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/conn_darwin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/conn_other.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/conn_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/conn_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/dbus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/decoder.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/default_handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/encoder.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/export.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/homedir.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/match.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/message.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/object.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/sequential_handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/server_interfaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/sig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/transport_nonce_tcp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/transport_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/transport_unixcred_freebsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/transport_unixcred_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/variant.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/variant_lexer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/godbus/dbus/v5/variant_parser.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gofrs/uuid/v5/codec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gofrs/uuid/v5/generator.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gofrs/uuid/v5/uuid.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/CONTRIBUTORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/call.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/callset.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/matchers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/btree/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/google/btree/btree_generic.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/cache/memory/memory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/collector/generic_collector.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/collector/prometheus_collector.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/collector/util.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/common/container_hints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/common/fsHandler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/common/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/common/inotify_watcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/grpc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/pkg/dialer/dialer_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/crio/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/crio/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/crio/handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/crio/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/crio/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/libcontainer/handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/libcontainer/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/raw/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/raw/handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/raw/watcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/systemd/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/devicemapper/thin_ls_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/devicemapper/thin_pool_watcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/btrfs/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/btrfs/mount.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/btrfs/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/devicemapper/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/devicemapper/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/devicemapper/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/fs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/nfs/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/nfs/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/overlay/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/overlay/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/tmpfs/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/tmpfs/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/vfs/install/install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/vfs/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/fs/vfs/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/info/v1/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/info/v1/machine.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/info/v2/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/machine/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/machine/machine.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/machine/operatingsystem_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/manager/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/manager/manager.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/metrics/prometheus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/metrics/prometheus_fake.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/metrics/prometheus_machine.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/nvm/machine_libipmctl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/nvm/machine_no_libipmctl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/collector_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/collector_no_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/manager_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/manager_no_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/types_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/perf/uncore_libpfm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/summary/percentiles.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/cpuload/cpuload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/cpuload/cpuload_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/cpuload/netlink/conn.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/cpuload/netlink/netlink.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/cpuload/netlink/reader.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/oomparser/oomparser.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/sysfs/sysfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/sysfs/sysfs_notx86.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/sysfs/sysfs_x86.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/utils/sysinfo/sysinfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/pprof/profile/profile.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/.golangci.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v2/volumes/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/backups/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/volumes/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/compute/v2/servers/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/compute/v2/servers/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/identity/v3/ec2tokens/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/identity/v3/projects/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/identity/v3/users/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/floatingips/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/routers/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/routers/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/routers/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/routers/urls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/networks/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/ports/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/networking/v2/ports/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/orchestration/v1/stacks/template.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/orchestration/v1/stacks/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/sharedfilesystems/v2/shares/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/sharedfilesystems/v2/shares/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/sharedfilesystems/v2/snapshots/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/sharedfilesystems/v2/snapshots/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/openstack/utils/choose_version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/pagination/pager.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/params.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/provider_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/results.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/testhelper/convenience.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/testhelper/http_responses.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/gophercloud/v2/util.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gophercloud/utils/v2/openstack/clientconfig/requests.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_metrics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/constants.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/reporter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_metrics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/COPYRIGHTis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/callmeta.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/reporter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client_metrics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client_reporter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/metric_options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_metrics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_reporter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/util.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.protois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2_protoopaque.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/constraint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/version_collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/karrick/godirwalk/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/karrick/godirwalk/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/karrick/godirwalk/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/karrick/godirwalk/azure-pipelines.ymlis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (30)
.github/workflows/pr.yaml.github/workflows/release.yamlDockerfileOWNERScharts/cinder-csi-plugin/Chart.yamlcharts/manila-csi-plugin/Chart.yamlcharts/openstack-cloud-controller-manager/Chart.yamldocs/cinder-csi-plugin/multi-region-clouds.mddocs/keystone-auth/using-keystone-webhook-authenticator-and-authorizer.mddocs/magnum-auto-healer/using-magnum-auto-healer.mddocs/octavia-ingress-controller/using-octavia-ingress-controller.mdexamples/webhook/keystone-deployment.yamlgo.modhack/release-image-digests.shimages/cinder-csi-plugin/Dockerfileimages/cloud-controller-manager/Dockerfileimages/manila-csi-plugin/Dockerfilemanifests/barbican-kms/ds.yamlmanifests/barbican-kms/pod.yamlmanifests/cinder-csi-plugin/cinder-csi-controllerplugin.yamlmanifests/cinder-csi-plugin/cinder-csi-nodeplugin.yamlmanifests/controller-manager/openstack-cloud-controller-manager-ds.yamlmanifests/controller-manager/openstack-cloud-controller-manager-pod.yamlmanifests/magnum-auto-healer/magnum-auto-healer.yamlmanifests/manila-csi-plugin/csi-controllerplugin.yamlmanifests/manila-csi-plugin/csi-nodeplugin.yamlpkg/openstack/loadbalancer.gopkg/openstack/loadbalancer_sg.gopkg/util/openstack/loadbalancer.gotests/playbooks/roles/install-golang/defaults/main.yml
|
|
||
| # example: | ||
| # ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml [v1.35.0] [v1.34.1] | ||
| # ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml [v1.36.0] [v1.35.0] |
There was a problem hiding this comment.
Avoid bracketed tags in the copy-paste example.
Line 18 shows tags as [v1.36.0] [v1.35.0]; if copied literally, brackets become part of the tag value and digest resolution fails. Use plain tags in the example.
Suggested tweak
-# ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml [v1.36.0] [v1.35.0]
+# ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml v1.36.0 v1.35.0📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml [v1.36.0] [v1.35.0] | |
| # ./release-image-digests.sh registry.k8s.io/images/k8s-staging-provider-os/images.yaml v1.36.0 v1.35.0 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@hack/release-image-digests.sh` at line 18, The example in
hack/release-image-digests.sh uses bracketed tags ("[v1.36.0] [v1.35.0]") which
will be copied verbatim and break digest resolution; update the example comment
line (the usage/sample line that currently shows
registry.k8s.io/images/k8s-staging-provider-os/images.yaml [v1.36.0] [v1.35.0])
to use plain tags without brackets (e.g., v1.36.0 v1.35.0) so copied values are
valid image tags.
Author
There was a problem hiding this comment.
This is from upstream. We can't fix that here.
There was a problem hiding this comment.
@stephenfin Understood — this is an upstream file and the fix would need to go there. Would you like me to resolve this comment? I can also open an upstream issue against kubernetes/cloud-provider-openstack to track the fix if that would be helpful.
stephenfin
force-pushed
the
sync-main-1.36
branch
from
cf9a5c0 to
71838c0
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
images/cloud-controller-manager/Dockerfile (1)
1-6: ⚡ Quick winDocument the builder/runtime OpenShift version skew or align versions.
Builder is
openshift-4.23but runtime remains4.22. This same pattern appears across all three Dockerfiles in this batch (manila-csi-plugin, cinder-csi-plugin, cloud-controller-manager), suggesting it may be intentional. Please either:
- Add a comment explaining why this version skew is intentional, or
- Verify alignment with release policy and update all three files consistently if it is not.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@images/cloud-controller-manager/Dockerfile` around lines 1 - 6, The Dockerfile shows a builder image FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-openshift-4.23 and a runtime image FROM registry.ci.openshift.org/ocp/4.22:base-rhel9 with a version skew; either document the intent or align versions: add a short comment above the FROM lines explaining why the builder uses openshift-4.23 while the runtime uses 4.22 (e.g., required build toolchain vs target runtime compatibility), or change the runtime FROM to match openshift-4.23 (and do the same consistent update across the other Dockerfiles that follow the same pattern such as the manila-csi-plugin and cinder-csi-plugin Dockerfiles) so versions are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@images/cloud-controller-manager/Dockerfile`:
- Around line 1-6: The Dockerfile shows a builder image FROM
registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-openshift-4.23 and a
runtime image FROM registry.ci.openshift.org/ocp/4.22:base-rhel9 with a version
skew; either document the intent or align versions: add a short comment above
the FROM lines explaining why the builder uses openshift-4.23 while the runtime
uses 4.22 (e.g., required build toolchain vs target runtime compatibility), or
change the runtime FROM to match openshift-4.23 (and do the same consistent
update across the other Dockerfiles that follow the same pattern such as the
manila-csi-plugin and cinder-csi-plugin Dockerfiles) so versions are consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 10f212d3-7dec-492e-96ee-72aa04ee8133
📒 Files selected for processing (4)
.ci-operator.yamlimages/cinder-csi-plugin/Dockerfileimages/cloud-controller-manager/Dockerfileimages/manila-csi-plugin/Dockerfile
✅ Files skipped from review due to trivial changes (1)
- .ci-operator.yaml
stephenfin
force-pushed
the
sync-main-1.36
branch
from
71838c0 to
b3b0eee
Compare
The ART bot will do this for us eventually: we're just getting a bit ahead of the curve. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
sync-main-1.36
branch
from
b3b0eee to
be6ca8d
Compare
Author
|
/test e2e-openstack e2e-openstack-csi-cinder |
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
mainwith the latest upstream release branch,release-1.36.❯ git diff upstream/release-1.35 -- \ ':!vendor' ':!DOWNSTREAM_OWNERS' ':!DOWNSTREAM_OWNERS_ALIASES' \ ':!.ci-operator.yaml' ':!.snyk' ':!images/*/Dockerfile'We should merge openshift/release#78860 at the same time.
Prior art
Summary by CodeRabbit