Skip to content

RHOAIENG-58626: Ignore ErrNotDynLinked for pandoc, py-spy, and rg#327

Open
ysok wants to merge 1 commit intoopenshift:mainfrom
ysok:RHOAIENG-58626-notebook-fips
Open

RHOAIENG-58626: Ignore ErrNotDynLinked for pandoc, py-spy, and rg#327
ysok wants to merge 1 commit intoopenshift:mainfrom
ysok:RHOAIENG-58626-notebook-fips

Conversation

@ysok
Copy link
Copy Markdown

@ysok ysok commented Apr 28, 2026

RHOAIENG-58626: Ignore ErrNotDynLinked for pandoc, py-spy, and rg

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2026

@ysok: This pull request references RHOAIENG-58626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from mrunalp and rhmdnd April 28, 2026 17:29
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ysok
Once this PR has been reviewed and has the lgtm label, please assign kolyshkin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

Hi @ysok. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ckhordiasma
Copy link
Copy Markdown

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2026
@smith-xyz
Copy link
Copy Markdown
Contributor

Please address the following:

  • Scope these to specific payload components ([[payload..ignore]]), not [[ignore]]. That is global so we don't want to apply that equally to all components.
  • Why are py-spy, pandoc, and rg in a production payload image? These are dev/convenience tools. If they're not required for the supported runtime, remove them from the image rather than ignoring the check.
  • If they truly can't be removed, each needs its own justification with a tracking issue for upstream resolution — not a single blanket ignore block.
  • "Transitive dependency" is a reason to fix the dep, not to ignore the check.

@smith-xyz
Copy link
Copy Markdown
Contributor

/hold for #327 (comment)

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2026
@ckhordiasma
Copy link
Copy Markdown

@ysok I'll defer to your team for a better explanation.. but my understanding is that these notebooks images--there are several, which is why an blanket ignore exception was requested--are essentially to provide dev environment-like containers for customers, right?

@ysok ysok force-pushed the RHOAIENG-58626-notebook-fips branch from 9c93edb to 8e6dc39 Compare May 8, 2026 14:06
@ysok ysok force-pushed the RHOAIENG-58626-notebook-fips branch from 8e6dc39 to e038b86 Compare May 8, 2026 14:07
@ysok
Copy link
Copy Markdown
Author

ysok commented May 8, 2026

@smith-xyz @ckhordiasma I just made another push with separation of each image with the jira ticket. Is this good enough or anything else needed?

Discussion at slack: https://redhat-internal.slack.com/archives/C07SBP17R7Z/p1776781639457179?thread_ts=1776778459.956129&cid=C07SBP17R7Z

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

@ysok: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants