Update/cli+readme#86
Conversation
… metadata clearing commands
- Updated functions to use `get_file_format` instead of `get_microsoft_format` for better compatibility with various file types. - Introduced a new `clear_file` function to handle metadata clearing based on file format. - Adjusted `clear_all` and `update_all` functions to utilize the new format handling logic. - Enhanced documentation to reflect support for a broader range of file formats.
- Updated the library overview to include support for image files (.png, .jpg, .jpeg, .gif). - Introduced a new list for supported image formats and combined it with existing Microsoft formats for a comprehensive format list.
- Renamed `get_microsoft_format` to `get_file_format` for broader applicability. - Updated the function to check against a unified list of supported formats instead of just Microsoft formats. - Enhanced documentation to clarify parameter types and return values.
AHReccese
added
documentation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ters - Added new functions: `get_file_format`, `clear_file`, `clear_all`, and `update_all`. - Updated existing functions: `clear` and `update`. - Removed `get_microsoft_format` function. - Enhanced CLI help text and updated pre-commit hooks. - Documented changes in the changelog.
|
@sadrasabouri |
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
Sorry for the delay. I missed the first review request.
My general suggestion is to have the supported formats save only in one place. Other places can refer to this set as "supported formats." This would save a lot of headaches further down for adding new formats.
Feel free to merge it and fix it in a follow up PR if it looks out-of-scope.
@sadrasabouri |
2 participants
Reference Issues/PRs
#50
What does this implement/fix? Explain your changes.
Note: After this PR, I will do a release PR.
Any other comments?