feat(charts): add values schemas#1340
Draft
ruirui6946 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
values.schema.jsonfiles for the controller, server, and all-in-one Helm chartsglobaldefault an actual empty objectWhy
The charts previously accepted misspelled keys and invalid scalar types until rendering or deployment. Inferred schemas also misclassify intentionally open values such as
globaland the floating-point Kubernetes client rate limits, so the schemas are maintained explicitly alongsidevalues.yaml.User impact
Valid existing values continue to render, while mistakes such as
controller.logLevlor a stringcontroller.replicaCountnow fail duringhelm lint,helm install, orhelm upgradebefore resources reach the cluster.Testing
Closes #1262