Preserve newlines when converting @CsvSource(textBlock = ...) to @ValueSource#998
Merged
Conversation
…ValueSource` When a `@CsvSource(textBlock = ...)` is replaced by `@ValueSource`, each value is now placed on its own indented line instead of being collapsed onto a single line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
CsvSourceToValueSourceconverts a multi-line@CsvSource(textBlock = """...""")to@ValueSource, each value is now placed on its own indented line instead of being collapsed onto a single line. Previously the textBlock branch produced output like@ValueSource(strings = {"a", "b", "c"}); it now produces a block-style array aligned with the annotation. Internal cleanup along the way: the five per-typeformat*helpers collapse into oneFunction<String,String>mapper pipeline usingCollectors.joining, and the custom indent helper is replaced withSpace.getIndent().Test plan
replaceTextBlockAttribute*test expectations to match the new layoutreplaceTextBlockAttributePlacesEachItemOnItsOwnLineregression test mirroring theFindLocaleDateTimeFormatsTestcase from the issue./gradlew testpasses