Fix JUnit4to5Migration for classes that extend org.junit.Assert#996
Merged
Conversation
Member
|
Thanks @motlin .. I'd marked this as draft to signify it should not be merged as is just yet. Instead we'll look to fix the recipe before merging. |
When a class extends `org.junit.Assert`, unqualified inherited assertion calls otherwise shadow the Jupiter static imports and keep resolving to the JUnit 4 overloads, producing code that fails to compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JUnit 4 to 5 migration produces broken code when a class
extends org.junit.Assertand uses unqualified inherited assertion methods. TheJUnit4to5Migrationaggregator:assertEquals/assertTrue,import org.junit.Assertandextends Assertunchanged.Because inherited methods shadow static imports in Java, the reordered call
assertEquals(1, 1, "expected message")resolves against JUnit 4'sAssert.assertEquals, which has no(int, int, String)overload, so the migrated code will not compile.I'm not sure what the proper fix should be, so I'm just submitting a test that demonstrates the broken output. The
afterblock reflects what the recipes actually produce today, so the test passes and CI stays green. Happy to help with the fix, but I don't have a clear idea of what it ought to be.