Fix EnclosedToNested failing with "Expected to find enclosing JavaSourceFile"#1001
Merged
Conversation
…ourceFile` `RemoveAnnotationVisitor` was invoked via `visitNonNull(cd, ctx)` with no parent cursor, so its visit walks up an isolated cursor chain that never reaches the enclosing `JavaSourceFile`. Pass `getCursor().getParentTreeCursor()` so it inherits the outer visitor's cursor stack, matching how `RemoveDuplicateTestTemplates` and `AddParameterizedTestAnnotation` invoke the same visitor.
…ed output The recipe now consistently inserts a blank line between the generated `tearDownStaticMocks()` and the next method, matching the spacing already present after `setUpStaticMocks()`. Update the expected output so the test reflects the consistent formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnclosedToNestedTestis currently failing 5/5 onmain(see the scheduled CI run on 2026-05-17).EnclosedToNested.visitClassDeclarationinvokes the innerRemoveAnnotationVisitorviavisitNonNull(cd, ctx)with no parent cursor. The inner visit therefore walks up an isolated cursor chain that never reaches the enclosingJavaSourceFile, and an internal lookup throwsIllegalStateException: Expected to find enclosing JavaSourceFile.The fix passes
getCursor().getParentTreeCursor()so the inner visitor inherits the outer cursor stack — matching howRemoveDuplicateTestTemplatesandAddParameterizedTestAnnotationalready invoke the same visitor.Test plan
EnclosedToNestedTestcases pass locally:recognizesTestAnnotationWithArgumentsmultipleInnerClassesdoesNotAnnotateNonTestInnerClassesrecognizesTestAnnotationWithTimeoutRuleAndArgumentsoneInnerClass