Fix assertEquals delta misinterpreted as message in AssertJ conversion#1000
Merged
Conversation
When the delta argument was a non-floating-point literal (e.g. `0`), `assertEquals(7f, getHeight(), 0)` was converted to `assertThat(getHeight()).as(0).isEqualTo(7f)` because the recipe checked the argument's expression type instead of the resolved method's parameter type. The compiler widens `0` to `float` to resolve `assertEquals(float, float, float)`, so the third argument is a delta. Now inspects the resolved parameter type, and inserts an explicit cast on the `within(...)` argument when the literal would otherwise resolve to a mismatched `Offset<T>` overload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assertions.assertEquals(7f, rect.getHeight(), 0)was converted toassertThat(rect.getHeight()).as(0).isEqualTo(7f)— the int literal0(the delta) was treated as the description. The recipe was inspecting the argument expression type, but the compiler widens0tofloatto resolveassertEquals(float, float, float), so the third position is actually a delta.mi.getMethodType().getParameterTypes().get(2)instead of the argument's expression type.within(...)overload (e.g.within(0)→Offset<Integer>againstisCloseTo(float, Offset<Float>)), an explicit cast is inserted:within((float) 0).After the fix,
Assertions.assertEquals(7f, rect.getHeight(), 0)becomes:Test plan
floatWithIntegerLiteralDeltacovers the reported caseJUnitAssertEqualsToAssertThatTestcases still pass (double/floatdeltas, boxedDouble.valueOf(...), integral actual with floating delta, message variants)