ARR: Bug fixes to the matching - #1278
Open
haroldrubio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes:
Fixed assignment config invitation IDs in assignments.py (line 123).
Avoid a bug where assignment configs were getting prefix by duplicated venue IDs
Made edge cleanup tolerate missing invitations in edge_utils.py (line 66).
Deleting optional/generated edge invitations now continues if the invitation was never created.
Fixed sanity checks to catch completely unassigned papers in sanity.py (line 143).
The check now iterates over venue submissions, not only papers that already have assignment edges to avoid missing unassigned papers
Fixed SAC/AC mapping in sanity.py (line 192).
It now flags an AC only when that AC’s assigned papers span multiple SACs, instead of doing a check by papers
Fixed deployed group membership sanity lookup in sanity.py (line 266).
Assignment edges are grouped by paper/submission, matching the submission group IDs.
Handle other ACs during SACMatching
ACs that were not assigned in a previous round may still appear in other rounds - meaning they could be missing an assigned SAC and/or conflicts. This PR assigns previously unassigned ACs to SACs in case a subsequent matching is too constrained and has to lean on another AC
Added SAC selection tie-break by owned AC count in sac_utils.py (line 605).
When conflict count and load are tied, SAC ownership is spread more evenly.