sync: upstream moxygen aca0f8665d5d#265
Merged
Merged
Conversation
…ation Summary: Add `quic::toFollySocketAddress()`, `quic::toFollySocketAddressRef()`, and `quic::fromFollySocketAddress<quic::SocketAddress>()` bridge calls at all boundaries where proxygen and moxygen code crosses between `folly::SocketAddress` and `quic::SocketAddress`. On server builds, `quic::SocketAddress` is an alias for `folly::SocketAddress`, so all bridge calls compile to identity with zero overhead. On mobile builds (where `quic::SocketAddress` will become `quic::QuicSocketAddress`), these conversions handle the type mismatch. **proxygen changes:** - `HQSession.h`: `getPeerAddress()`/`getLocalAddress()` use `toFollySocketAddressRef()` with mutable `folly::SocketAddress` caches (`cachedPeerAddr_`, `cachedLocalAddr_`) - `HQSession.cpp`: Wrap `sock_->getLocalAddress()`/`getPeerAddress()` assignments to `localAddr_`/`peerAddr_` with `toFollySocketAddress()` - `HQConnector.cpp`: Wrap `addNewPeerAddress()`/`setLocalAddress()` args with `fromFollySocketAddress<quic::SocketAddress>()` - `QuicWebTransport.h`, `QuicWtSession.h`: Same `toFollySocketAddressRef()` pattern with mutable caches - `HTTPCoroSession.cpp`: Wrap `sock->getLocalAddress()`/`getPeerAddress()` passed to constructor with `toFollySocketAddress()` - `HTTPCoroConnector.cpp`: Wrap `addNewPeerAddress()`/`setLocalAddress()` args with `fromFollySocketAddress<quic::SocketAddress>()` - `HTTPCoroAcceptor.cpp`: Wrap `quicSocket->getPeerAddress()` with `toFollySocketAddress()` - `HTTPServer.cpp`: Update `QuicAcceptorTransportFactory::make()` override signature from `const folly::SocketAddress&` to `const quic::SocketAddress&` to match renamed base class **moxygen changes:** - `MoQClientBase.cpp`: Wrap `quicClient->getLocalAddress()`/`getPeerAddress()` with `toFollySocketAddress()` before passing to `MLogger` - `MoQClientMobile.cpp`: Wrap `addNewPeerAddress()` arg with `fromFollySocketAddress<quic::SocketAddress>()` - `MoQServer.cpp`: Wrap address getters with `toFollySocketAddress()` at both logger call sites - `MoQWebTransportClient.cpp`: Wrap `session->getLocalAddress()`/`getPeerAddress()` with `toFollySocketAddress()` - `util/QuicConnector.cpp`: Wrap `addNewPeerAddress()` arg with `fromFollySocketAddress<quic::SocketAddress>()` Re-land of reverted D106696601. This diff was reverted only as collateral: it stacks on D106696595, which was reverted for an ARVR Android Buck link-group cycle (context: S672298). It has no independent build break — on server `quic::SocketAddress` is an alias for `folly::SocketAddress`, so every bridge call is identity. Reviewed By: jbeshay Differential Revision: D107912134 fbshipit-source-id: 4b1ba7b6166a35d966b4f3c9e5d87a3c81efb474
Summary: GitHub commits: facebook/CacheLib@8c7e5bf facebook/fb303@56389aa facebook/fbthrift@92a809f facebook/folly@ef07b76 facebook/mvfst@f98bd76 facebook/proxygen@7558747 facebook/wangle@dc6de26 react/yoga@f6206ec facebookexperimental/edencommon@de9c9e1 facebookexperimental/rust-shed@a1180d1 facebookincubator/fizz@11216ba fbshipit-source-id: b0de11407b306b6b502074c7ee237c4a0e9070dd
Summary: Gate `PUBLISH_OK` wire compatibility so draft 18 sends publish success as `REQUEST_OK`, while older drafts continue to use wire `PUBLISH_OK`. Add `RequestOk`/`PublishOk` conversion helpers and route semantic publish success through existing session handling, including `MoQRelaySession`. Reviewed By: sharmafb Differential Revision: D106771143 fbshipit-source-id: 63b13deebdf338b07e40ca445549a03719c80434
Summary: Two follow-up tightenings to D106771143's deliberately-permissive draft-18 param validation: (1) reject `OBJECT_DELIVERY_TIMEOUT`/`SUBGROUP_DELIVERY_TIMEOUT` on any resolved `REQUEST_OK` shorthand except `PUBLISH_OK`; (2) make `isKnownParamKey` version-aware so draft-18-only keys (0x06/0x0A/0x34) are hard-rejected below v18. Reviewed By: sharmafb Differential Revision: D107959157 fbshipit-source-id: 93695efd88f92233febad027cdafbccf47558d94
Summary: We don't need this patch function in `run-getdeps.py`, we can just add the flag directly to the boost-python manifest. Differential Revision: D108040039 fbshipit-source-id: 0d20ed8140c3edbb2fa6572ef28de2167b87cb3c
omoq-sync-bot
Bot
requested review from
Oxyd,
TimEvens,
afrind,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
gmarzot
approved these changes
Jun 10, 2026
gmarzot
left a comment
gmarzot
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approved by upstream sync workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream sync.
aca0f8665d5dThe verify workflow will validate the standalone build. On success, this PR auto-merges.
Devs can push conflict-resolution commits to
sync/aca0f8665d5dif needed.Created by
omoq-upstream-syncworkflow.This change is