Skip to content

Remove CODEOWNERS (advisory-only, no merge gating)#264

Merged
gmarzot merged 1 commit into
mainfrom
remove-codeowners
Jun 10, 2026
Merged

Remove CODEOWNERS (advisory-only, no merge gating)#264
gmarzot merged 1 commit into
mainfrom
remove-codeowners

Conversation

@gmarzot

@gmarzot gmarzot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

What

Delete CODEOWNERS and remove the now-dangling reference to it from .github/CONTRIBUTING.md.

Why

Branch protection on main has require_code_owner_reviews: false, so CODEOWNERS never gated merges. Its only live effect was auto-requesting review from all nine listed owners on every PR — review noise with no compensating enforcement.

Nothing about how merges actually work changes:

  • The required single approving review can still come from any collaborator with write access.
  • The merge button stays independently restricted via branch-protection restrictions (suhasHere, afrind, gmarzot, + the sync bot app); admins can still --admin override.
  • No workflow or tooling reads CODEOWNERS (the auto-merge workflow gates on an existing approval + green checks, not code owners).

Reviewers can still be assigned per-PR as needed; this just drops the noisy auto-assignment default.


This change is Reviewable

Branch protection on main has require_code_owner_reviews=false, so
CODEOWNERS never gated merges — it only auto-requested review from all
nine listed owners on every PR. The required single approving review can
come from any collaborator, and the merge button is independently
restricted via branch-protection restrictions. Removing the file stops
the auto-review noise with no change to enforcement.

Also drop the now-dangling CODEOWNERS reference from CONTRIBUTING.md.

@michalhosna michalhosna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalhosna reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on afrind, akash-a-n, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

@gmarzot gmarzot merged commit 08c574d into main Jun 10, 2026
7 checks passed
@gmarzot gmarzot deleted the remove-codeowners branch June 10, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants