[for upstream] mlog: Add async I/O and directory prefix support to FileMLogger#236
Open
akash-a-n wants to merge 1 commit into
Open
[for upstream] mlog: Add async I/O and directory prefix support to FileMLogger#236akash-a-n wants to merge 1 commit into
akash-a-n wants to merge 1 commit into
Conversation
akash-a-n
requested review from
Oxyd,
TimEvens,
afrind,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
akash-a-n
force-pushed
the
feature/mlog-async-io
branch
from
91d5638 to
b55c9cf
Compare
- Add setWriteExecutor() for asynchronous off-thread disk I/O - Pre-format logs on calling thread, move serialized data to executor - Add setDir() for directory prefix support via derivePath() - Avoid this capture by moving all data into lambda - Update FileMLoggerFactory to support new features - Add test coverage for FileMLogger and FileMLoggerFactory
akash-a-n
force-pushed
the
feature/mlog-async-io
branch
from
b55c9cf to
bb7b287
Compare
afrind
approved these changes
Jun 1, 2026
afrind
left a comment
afrind
left a comment
Collaborator
There was a problem hiding this comment.
@afrind reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gmarzot, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).
Collaborator
|
Upstream PR: facebookexperimental#186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is