Skip to content

Remove CODEOWNERS (advisory-only, no merge gating)#396

Merged
gmarzot merged 2 commits into
mainfrom
remove-codeowners
Jun 10, 2026
Merged

Remove CODEOWNERS (advisory-only, no merge gating)#396
gmarzot merged 2 commits into
mainfrom
remove-codeowners

Conversation

@gmarzot

@gmarzot gmarzot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What

  • Delete CODEOWNERS.
  • Drop the stale "no auto-reviewer request" note from the Draft bullet in CONTRIBUTING.md (with CODEOWNERS gone, no PR triggers an auto-reviewer request, so it's no longer a draft-only distinction).

Why

Branch protection on main has require_code_owner_reviews: false, so CODEOWNERS never gated merges. Its only live effect was auto-requesting review from all nine listed owners on every PR — review noise with no compensating enforcement.

Nothing about how merges actually work changes:

  • The required single approving review can still come from any collaborator with write access.
  • The merge button stays independently restricted via branch-protection restrictions (suhasHere, afrind, gmarzot, + the sync bot app); admins can still --admin override.
  • No workflow or tooling reads CODEOWNERS (the auto-merge workflow gates on an existing approval + green checks, not code owners).

Note: the deleted file's header comment claimed code-owner review was required and that the merge button was restricted to all nine listed users — both were inaccurate (review was advisory, merge is restricted to three). Dropping the file removes that misleading doc as well.

Reviewers can still be assigned per-PR as needed; this just drops the noisy auto-assignment default.


This change is Reviewable

Branch protection on main has require_code_owner_reviews=false, so
CODEOWNERS never gated merges — it only auto-requested review from all
nine listed owners on every PR. The required single approving review can
come from any collaborator, and the merge button is independently
restricted via branch-protection restrictions. Removing the file stops
the auto-review noise with no change to enforcement.

@michalhosna michalhosna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@michalhosna made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on afrind, akash-a-n, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

@michalhosna michalhosna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalhosna reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on afrind, akash-a-n, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

With CODEOWNERS removed, no PR triggers an auto-reviewer request, so the
Draft bullet no longer needs to call it out as a draft-only distinction.
@gmarzot gmarzot merged commit a044b18 into main Jun 10, 2026
15 of 16 checks passed
@gmarzot gmarzot deleted the remove-codeowners branch June 10, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants