8385670: Incorrect warning: Unexpected gaps for Klass alignment#31334
Open
iklam wants to merge 2 commits into
Open
8385670: Incorrect warning: Unexpected gaps for Klass alignment#31334iklam wants to merge 2 commits into
iklam wants to merge 2 commits into
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
…for-klass-alignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several bugs in the logging of the allocation gaps in the AOT cache. After UseCompactObjectHeader becomes the default, we quite often get spurious waring of unfilled gaps when dumping dynamic CDS archives:
After the fix:
(8 / (2944 + 8)) == 0.0027100271002710027
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31334/head:pull/31334$ git checkout pull/31334Update a local copy of the PR:
$ git checkout pull/31334$ git pull https://git.openjdk.org/jdk.git pull/31334/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31334View PR using the GUI difftool:
$ git pr show -t 31334Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31334.diff
Using Webrev
Link to Webrev Comment