Skip to content

8385664: Stale comment about JDK-6996415#31332

Open
cushon wants to merge 1 commit into
openjdk:masterfrom
cushon:JDK-8385664
Open

8385664: Stale comment about JDK-6996415#31332
cushon wants to merge 1 commit into
openjdk:masterfrom
cushon:JDK-8385664

Conversation

@cushon
Copy link
Copy Markdown
Contributor

@cushon cushon commented May 31, 2026

This change removes an obsolete comment in TransTypes about JDK-6996415

once JDK-6996415 is solved it should be checked if this approach can be applied to method addOverrideBridgesIfNeeded

JDK-6996415 was fixed in JDK 7. The fix for JDK-6996415 disabled the call to addOverrideBridgesIfNeeded here, and addOverrideBridgesIfNeeded was later removed in JDK-8032188.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8385664: Stale comment about JDK-6996415 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31332/head:pull/31332
$ git checkout pull/31332

Update a local copy of the PR:
$ git checkout pull/31332
$ git pull https://git.openjdk.org/jdk.git pull/31332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31332

View PR using the GUI difftool:
$ git pr show -t 31332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31332.diff

Using Webrev

Link to Webrev Comment

@cushon cushon marked this pull request as ready for review May 31, 2026 13:19
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 31, 2026

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 31, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the compiler compiler-dev@openjdk.org label May 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 31, 2026

@cushon The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 31, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant