8385369: G1: Concurrent Cleanup For Next Mark accesses uncommitted bitmaps after region uncommit#31308
Open
tschatzl wants to merge 1 commit into
Open
Conversation
Hi all, please review this change that fixes a crash during concurrent bitmap clearing: regions and their associated bitmaps may be uncommitted after freeing them in a gc that runs during that time, while they are being cleared. This obviously crashes the VM. There is a test, but it is not very reliable and I did not manage to further improve it - in one run it crashes in <1% of cases, in another in almost 10% of cases. Feel free to ask me to remove it. Testing: new test, gha Thanks, Thomas
|
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
please review this change that fixes a crash during concurrent bitmap clearing: regions and their associated bitmaps may be uncommitted after freeing them in a gc that runs during that time, while they are being cleared.
This obviously crashes the VM.
There is a test, but it is not very reliable (does not fail often without the patch) and I did not manage to further improve it - in one run it crashes in <1% of cases, in another in almost 10% of cases. Feel free to suggest to remove it.
Testing: new test, gha
Thanks,
Thomas
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31308/head:pull/31308$ git checkout pull/31308Update a local copy of the PR:
$ git checkout pull/31308$ git pull https://git.openjdk.org/jdk.git pull/31308/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31308View PR using the GUI difftool:
$ git pr show -t 31308Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31308.diff
Using Webrev
Link to Webrev Comment