8384250: [macos] Test tools/jpackage/share/AsyncTest.java failed

[sashamatveev]

• Fixed by ignoring ".BC.*" temp file which is transient Finder metadata.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8384250: [macos] Test tools/jpackage/share/AsyncTest.java failed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31304/head:pull/31304
$ git checkout pull/31304

Update a local copy of the PR:
$ git checkout pull/31304
$ git pull https://git.openjdk.org/jdk.git pull/31304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31304

View PR using the GUI difftool:
$ git pr show -t 31304

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31304.diff

Using Webrev

Link to Webrev Comment

[sashamatveev]

@alexeysemenyukoracle Please review.

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@sashamatveev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e7adfe9)

[alexeysemenyukoracle]

I don't see how this is the right fix to ignore that jpackage adds files matching ".BC.*" pattern to DMG archive.

[sashamatveev]

I think it is not clear if file gets added to DMG image when it is created or if it was added to unpack folder when DMG was unpacked. I tried to reproduce this issue many times and so far was not able to reproduce it. What is you suggestion? Technically it can be added when we prepared image, during it was copied to DMG or when osascript was running.

One possible solution is to ignore it during unpacking and verify read-only DMG image after we created it to make sure this file does not exist and if exist then remove it from DMG after converting it to write-read and keep doing until this file is gone.

[alexeysemenyukoracle]

Good point that it is unclear whether this file is part of a DMG or was added to a mounted volume during the test.

I suggest we figure this out first. This way, we will know whether to fix the implementation or the test lib.