Remove jvmci and graal references from the guide#174
Conversation
|
👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into |
|
@mhaessig This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
irisclark
left a comment
There was a problem hiding this comment.
Similar changes may also be needed in https://github.com/openjdk/skara/blob/master/config/mailinglist/rules/jdk.json
|
Thank you for the pointer. I opened openjdk/skara#1776. |
|
Thank you for reviewing! /integrate |
|
/sponsor |
|
@dholmes-ora Only Committers are allowed to sponsor changes. |
JesperIRL
left a comment
There was a problem hiding this comment.
For the directories removed in the Code Owners section, please add them to the section below "Directories removed".
|
@JesperIRL, done in the latest commit. |
With the removal of JVMCI and Graal from openJDK, we should also remove such references from the Guide.
Progress
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/174/head:pull/174$ git checkout pull/174Update a local copy of the PR:
$ git checkout pull/174$ git pull https://git.openjdk.org/guide.git pull/174/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 174View PR using the GUI difftool:
$ git pr show -t 174Using diff file
Download this PR as a diff file:
https://git.openjdk.org/guide/pull/174.diff
Using Webrev
Link to Webrev Comment