Skip to content

Remove jvmci and graal references from the guide#174

Open
mhaessig wants to merge 2 commits into
openjdk:masterfrom
mhaessig:remove-jvmci
Open

Remove jvmci and graal references from the guide#174
mhaessig wants to merge 2 commits into
openjdk:masterfrom
mhaessig:remove-jvmci

Conversation

@mhaessig
Copy link
Copy Markdown
Contributor

@mhaessig mhaessig commented May 26, 2026

With the removal of JVMCI and Graal from openJDK, we should also remove such references from the Guide.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/174/head:pull/174
$ git checkout pull/174

Update a local copy of the PR:
$ git checkout pull/174
$ git pull https://git.openjdk.org/guide.git pull/174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 174

View PR using the GUI difftool:
$ git pr show -t 174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/guide/pull/174.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 26, 2026

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

@mhaessig This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Remove jvmci and graal references from the guide

Reviewed-by: iris, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the rfr label May 26, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 26, 2026

Webrevs

Copy link
Copy Markdown
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhaessig
Copy link
Copy Markdown
Contributor Author

Thank you for the pointer. I opened openjdk/skara#1776.

Copy link
Copy Markdown

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@openjdk openjdk Bot added the ready label May 27, 2026
@mhaessig
Copy link
Copy Markdown
Contributor Author

Thank you for reviewing!

/integrate

@openjdk openjdk Bot added the sponsor label May 28, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 28, 2026

@mhaessig
Your change (at version 6d7a9a0) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 28, 2026

@dholmes-ora Only Committers are allowed to sponsor changes.

Copy link
Copy Markdown
Member

@JesperIRL JesperIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the directories removed in the Code Owners section, please add them to the section below "Directories removed".

@mhaessig
Copy link
Copy Markdown
Contributor Author

@JesperIRL, done in the latest commit.

@openjdk openjdk Bot removed the sponsor label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants