14: Make expected OpenSSL version build metadata string configurable.#9
14: Make expected OpenSSL version build metadata string configurable.#9jon-oracle wants to merge 1 commit into
Conversation
|
👋 Welcome back jspillett! A progress list of the required criteria for merging this PR into |
|
@jon-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
At present the OpenSSL interface tests expect the version build metadata string reported by the OpenSSL cryptography library to be the empty string.
This is the default value reported by a build of the OpenSSL.
However a custom build of OpenSSL may set a non-empty string. The test therefore should not assume that it will be the empty string and instead only check for a string if supplied.
Progress
Warning
14: Make expected OpenSSL version build metadata string configurable.Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/brisbane.git pull/9/head:pull/9$ git checkout pull/9Update a local copy of the PR:
$ git checkout pull/9$ git pull https://git.openjdk.org/brisbane.git pull/9/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9View PR using the GUI difftool:
$ git pr show -t 9Using diff file
Download this PR as a diff file:
https://git.openjdk.org/brisbane/pull/9.diff
Using Webrev
Link to Webrev Comment