Skip to content

14: Make expected OpenSSL version build metadata string configurable.#9

Open
jon-oracle wants to merge 1 commit into
openjdk:masterfrom
jon-oracle:build-metadata
Open

14: Make expected OpenSSL version build metadata string configurable.#9
jon-oracle wants to merge 1 commit into
openjdk:masterfrom
jon-oracle:build-metadata

Conversation

@jon-oracle
Copy link
Copy Markdown

@jon-oracle jon-oracle commented May 29, 2026

At present the OpenSSL interface tests expect the version build metadata string reported by the OpenSSL cryptography library to be the empty string.

This is the default value reported by a build of the OpenSSL.

However a custom build of OpenSSL may set a non-empty string. The test therefore should not assume that it will be the empty string and instead only check for a string if supplied.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 14: Make expected OpenSSL version build metadata string configurable.

Issue

  • BRISBANE-14: Make expected OpenSSL version build metadata string configurable. (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/brisbane.git pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/brisbane.git pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/brisbane/pull/9.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 29, 2026

👋 Welcome back jspillett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 29, 2026

@jon-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

14: Make expected OpenSSL version build metadata string configurable.

Reviewed-by: eodea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title BRISBANE-14 Make expected OpenSSL version build metadata string configurable. 14: Make expected OpenSSL version build metadata string configurable. May 29, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 29, 2026
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 29, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 29, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants