Add parameter dispatching when calling the inner workflow#61
Conversation
|
ivan-risueno
changed the title
| provisionerActionsApiValidator.validateMandatoryFields(requiredCatalogItemParamsWrapper.toProvisionAction(), catalogItem); | ||
| var updateProvisionActionWithoutPlaceholdersWrapper = placeholderPostProcessor.process(requiredCatalogItemParamsWrapper); | ||
| var workflowWrapperParamsActionWrapper = addProvisionWorkflowWrapper(requiredCatalogItemParamsWrapper); | ||
| provisionerActionsApiValidator.validateWorkflowPresence(workflowWrapperParamsActionWrapper.toProvisionAction()); |
There was a problem hiding this comment.
It does not make sense to validate and object, and use another one later on. (Even when they should be virtuallly equals.
Better to create the object, validate it, and reuse it later on.
var provisionAction = workflowWrapperParamsActionWrapper.toProvisionAction(); provisionerActionsApiValidator.validateWorkflowPresence(provisionAction); provisionerActionsApiValidator.validateMandatoryFields(provisionAction, catalogItem);
| ); | ||
| } | ||
|
|
||
| var dispatchedWorkflowParams = provisionActionWrapperWithoutWorkflowInfo.getParametersMap().values().stream().map(ProvisionActionParameter::getName).collect(Collectors.toSet()); |
There was a problem hiding this comment.
I would suggest to follow normal stream format, I mean
var dispatchedWorkflowParams = provisionActionWrapperWithoutWorkflowInfo.getParametersMap().values().stream() .map(ProvisionActionParameter::getName) .collect(Collectors.toSet());
| .build() | ||
| ); | ||
| } | ||
| var dispatchedWorkflowParams = action.getParameters().stream().map(CreateIncidentParameter::getName).collect(Collectors.toSet()); |
There was a problem hiding this comment.
3 participants
No description provided.