Add explicit Rows control so tall frames pack a full grid#66
Merged
Conversation
Per row alone fixed cell width and let rows fall out of whatever the page height allowed, so tall frames at 2-up overflowed to a single row (2 per page) and left the sheet half empty. Add a Rows setting and size each cell to fit both the column-width and row-height budgets, centring the grid on the printable area. A tall 2x2 now packs four frames and fills the page; the count per sheet is exactly perRow x rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Rows stepper next to Per row so the sheet is an explicit
perRow × rowsgrid.Why
"Per row" alone fixed each cell's width and let the row count fall out of whatever the page height allowed. A tall frame at 2-up is ~140 mm tall on A4, so two rows overflowed the 277 mm usable height by a hair — it dropped to one row → 2 frames per page, leaving the sheet half empty.
How
sheetLayoutnow takesrowsand sizes each cell to the largest that fits both the column-width and row-height budgets (tall shapes are height-bound), then centres the grid on the printable area, splitting slack evenly. Frames per sheet =perRow × rows, independent of shape.A tall 2×2 now packs four frames and fills the page; square/wide center cleanly with even margins. Threaded through the preview, PDF export, and project/session settings (old files fall back to the default).
Verified live: tall page 2×2 = 4 fills the sheet, square page 2×2 = 4 centers; typecheck + lint clean.
🤖 Generated with Claude Code