fix: enforce ONE_TIME pre-approvals as single-use#44
Merged
Conversation
Adds preApprovalRedeemError(pa, now) returning the failure reason (inactive / expired / exhausted) or null. ONE_TIME codes are single-use regardless of maxUses. Covered by a unit-test matrix.
The redeem route only checked maxUses (null = unlimited), so a ONE_TIME code stayed redeemable after use. Route the eligibility check through the shared preApprovalRedeemError helper, which treats ONE_TIME as effective max 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (found while testing PR #43): a
ONE_TIMEpre-approval was reusable. The redeem route only checkedmaxUses(null = unlimited) and never enforced the ONE_TIME semantic, so a one-time code stayed Active and redeemable after use.Fix
preApprovalRedeemError(pa, nowMs)→ returns the failure reason (invalid or inactive code/code expired/code exhausted) or null. ONE_TIME → effective max 1 use, regardless of maxUses. Checks in order: inactive → expired → exhausted.Verified