lacp: add fallback-timeout configuration to aggregate interfaces#1473
lacp: add fallback-timeout configuration to aggregate interfaces#1473aamirshah2k wants to merge 4 commits intoopenconfig:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'fallback-timeout' leaf to the LACP statistics grouping in the OpenConfig YANG model. The review identifies that the description string for this new leaf exceeds the 70-character line length limit recommended by the project's style guidelines and provides a corrected suggestion.
|
/gcbrun |
|
No major YANG version changes in commit 370b097 |
|
This looks good to me, thank you for providing the implementation references. Scheduled for review in April 14, 2026 OC operators review. I am going to mark this last call now with merge target date of April 14,2026 since this is rather straightforward. |
|
/gcbrun |
|
Reviewed at OC Operators Meeting April 14th, 2026: Still need the author to fix the failing CI checks. The units of uint16 seem okay (vendor max are 300 / 3600 seconds; both of which are smaller than 2^16). Since fallback already exists, this seems reasonable. Will re-review once the CI checks are passing (@dplore left a comment on how to fix it with OC version update.) |
Co-authored-by: Darren Loher <dloher@google.com>
|
/gcbrun |
|
/gcbrun |
Change Scope
Platform Implementations
port-channel lacp fallback timeout <seconds>command in EOSlacp-fallback-timeout <seconds>command in SR Linuxbundle lacp-fallback timeout <seconds>command in IOS-XRTree View