updated deviations for juniper in record_subscribe_non_grpc

[Eeramma]

added deviations for shell accounting. shell commands are not accounted for juniper added deviations accordingly. Channel id is not supported in acctz record.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test suite for non-gRPC record subscriptions to accommodate specific platform behaviors regarding shell command accounting. By introducing a new deviation flag, the changes ensure that tests correctly handle environments where shell command accounting is not supported, preventing false failures during validation.

Highlights

• Added Deviation: Introduced acctz_shell_cmd_accounting_unsupported to the metadata configuration to account for Juniper platform limitations.
• Test Logic Update: Updated the non-gRPC record subscription test to conditionally skip channel ID validation based on the new platform deviation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5346 / 1a7e3ff

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8000E		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco XRd		ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper ncPTX		ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia SR Linux		ACCTZ-3.1: Record Subscribe Non-gRPC
Openconfig Lemming		ACCTZ-3.1: Record Subscribe Non-gRPC

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8808		ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper PTX10008		ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia 7250 IXR-10e		ACCTZ-3.1: Record Subscribe Non-gRPC

Help

[gemini-code-assist]

Code Review

This pull request introduces a new platform exception for shell command accounting in the metadata and modifies a test to skip a ChannelId validation using an existing deviation. However, the review feedback indicates that using the AcctzRecordFailCommandUnsupported deviation for this purpose is semantically incorrect. It is recommended to create a dedicated deviation, such as AcctzChannelIdUnsupported, to ensure the test logic remains clear and the deviation's purpose is not overloaded.

[ram-mac]

@Eeramma - There are some static failures due to formating errors. Please take a look and also there are conflicts.

[ram-mac]

LGTM