fix(containerztest): use CLI().Run() for Cisco device config

[youssefyamoutyy]

Changed Cisco case in Client() function to use dut.CLI().Run(t, ...) instead of dut.Config().New().WithCiscoText(...).Append(t)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the device configuration handling for Cisco devices within the test suite. By switching to the CLI execution method, the implementation ensures more direct interaction with the device's command-line interface for applying necessary network access configurations.

Highlights

• Cisco Configuration Method: Updated the Cisco device configuration logic to use the CLI().Run() method instead of the Config().New().WithCiscoText() approach.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5336 / 06e3f45

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request modifies the Cisco device configuration in internal/containerztest/containerztest.go by replacing the dut.Config() method with dut.CLI().Run(). However, the feedback points out that combining EXEC mode commands (appmgr) and configuration mode commands (ipv6 access-list) in a single CLI call will likely fail on Cisco IOS-XR. It is recommended to separate these commands and use the preferred dut.Config().Append() method for the access-list to ensure transactional consistency and alignment with repository standards.

[gemini-code-assist]

The appmgr command is an EXEC mode command on Cisco IOS-XR, while ipv6 access-list is a configuration mode command. Executing both in a single dut.CLI().Run() call will likely fail because the session will not be in configuration mode for the ACL commands. Additionally, the repository standard is to use dut.Config().Append() for configuration to ensure transactional consistency and alignment with other vendor implementations. It is recommended to separate the EXEC command and use the preferred configuration method for the ACL.

		dut.CLI().Run(t, "appmgr docker allow-sensitive-paths")
		dut.Config().New().WithCiscoText("ipv6 access-list restrict-access-ipv6\n  ! open port for cntrsrv from PROD\n  permit tcp any any eq 60061").Append(t)

[youssefyamoutyy]

addressed in 06e3f45