Create NHG-based policer feature profile and remove deprecated test#5327
Create NHG-based policer feature profile and remove deprecated test#5327trlongth wants to merge 3 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the QoS policing feature profiles by introducing a new approach to policing traffic based on Next-Hop Groups (NHG) using policy-forwarding with MATCH_ACTION. This change replaces an older, deprecated test, ensuring that the feature profiles reflect current best practices and hardware capabilities. The update provides clear documentation and schema examples for implementing and verifying NHG-based policing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the DP-2.2 feature profile by replacing the legacy QoS classifier-based policing test with a modern approach using Policy-Forwarding MATCH_ACTION. The changes include deleting the old test files and introducing a new README that outlines the updated procedure and schema. The review feedback correctly identifies a JSON syntax error in the documentation examples and suggests including missing interface application details in both the canonical configuration snippet and the path coverage section to ensure completeness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR adds a new feature profile for NHG-based policing using MATCH_ACTION in policy forwarding, and removes the deprecated ingress_police_nhg test. It includes the README with test cases and proposed schema.