Skip to content

Create NHG-based policer feature profile and remove deprecated test#5327

Open
trlongth wants to merge 3 commits intoopenconfig:mainfrom
trlongth:ingress-police-nhg-match-action
Open

Create NHG-based policer feature profile and remove deprecated test#5327
trlongth wants to merge 3 commits intoopenconfig:mainfrom
trlongth:ingress-police-nhg-match-action

Conversation

@trlongth
Copy link
Copy Markdown
Contributor

@trlongth trlongth commented Apr 8, 2026

This PR adds a new feature profile for NHG-based policing using MATCH_ACTION in policy forwarding, and removes the deprecated ingress_police_nhg test. It includes the README with test cases and proposed schema.

@trlongth trlongth requested review from a team as code owners April 8, 2026 22:59
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 8, 2026

Pull Request Functional Test Report for #5327 / 1d9ee42

No tests identified for validation.

Help

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the QoS policing feature profiles by introducing a new approach to policing traffic based on Next-Hop Groups (NHG) using policy-forwarding with MATCH_ACTION. This change replaces an older, deprecated test, ensuring that the feature profiles reflect current best practices and hardware capabilities. The update provides clear documentation and schema examples for implementing and verifying NHG-based policing.

Highlights

  • New Feature Profile: A new feature profile for NHG-based policing using MATCH_ACTION in policy forwarding has been introduced, aligning with modern hardware architectures for QoS.
  • Deprecated Test Removal: The deprecated ingress_police_nhg test, including its README, Go test file, and metadata, has been removed.
  • Updated Documentation: The new feature profile includes a comprehensive README detailing the summary, topology, test setup, procedure, test cases, and proposed OpenConfig schema for NHG-based policing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DP-2.2 feature profile by replacing the legacy QoS classifier-based policing test with a modern approach using Policy-Forwarding MATCH_ACTION. The changes include deleting the old test files and introducing a new README that outlines the updated procedure and schema. The review feedback correctly identifies a JSON syntax error in the documentation examples and suggests including missing interface application details in both the canonical configuration snippet and the path coverage section to ensure completeness.

Comment thread feature/qos/ingress_policer/otg_tests/ingress_police_nhg_match_action/README.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants