[RT-2.11] Watch AFT entries instead of Get#5311
[RT-2.11] Watch AFT entries instead of Get#5311yini101 wants to merge 1 commit intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the ISIS interface level passive test to improve reliability when verifying AFT entries. By transitioning from an immediate get operation to a watch operation with a defined timeout, the test now correctly handles the latency required for the device under test to update its forwarding table after IS-IS adjacency transitions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5311 / 5cfb56dVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ISIS interface level passive test to use gnmi.Watch instead of gnmi.Get for verifying IPv4 and IPv6 AFT entries, which improves reliability by allowing for state convergence. The review feedback suggests simplifying the watch predicates to use val.IsPresent(), noting that the current prefix comparisons are redundant because the paths are already keyed by the routes and may be flaky for IPv6 due to different string representations.
|
/fptest hardware |
Replace gnmi.Get with gnmi.Watch (2-minute timeout) for IPv4 and IPv6 AFT entry checks in Route_checks. After disabling IS-IS passive and awaiting adjacency UP, the dut requires additional time to settle before the AFT entry is visible via gNMI.
3 participants
Replace gnmi.Get with gnmi.Watch (2-minute timeout) for IPv4 and IPv6 AFT entry checks in Route_checks. After disabling IS-IS passive and awaiting adjacency UP, the dut requires additional time to settle before the AFT entry is visible via gNMI.