Skip to content

[RT-7.9] Update wait times for convergence#5310

Open
yini101 wants to merge 1 commit intoopenconfig:mainfrom
yini101:rt-7.9
Open

[RT-7.9] Update wait times for convergence#5310
yini101 wants to merge 1 commit intoopenconfig:mainfrom
yini101:rt-7.9

Conversation

@yini101
Copy link
Copy Markdown
Contributor

@yini101 yini101 commented Apr 7, 2026

Increase gnmi.Watch timeout in verifyBGPPrefixesTelemetry from 30s to 2 minutes to allow sufficient time for initial BGP prefix advertisement over IS-IS loopback sessions to propagate to DUT telemetry.

Increase sleep in enableMultipath (Arista deviation path) from 30s to 60s to ensure EOS fully programs the 3-path ECMP FIB before traffic validation begins, preventing transient packet loss during hardware convergence.

@yini101 yini101 requested a review from a team as a code owner April 7, 2026 03:05
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts timing parameters within the BGP multipath test suite to improve stability. By increasing wait times for telemetry updates and hardware programming, the changes prevent race conditions and transient failures during network convergence.

Highlights

  • Telemetry Timeout Extension: Increased the gnmi.Watch timeout from 30 seconds to 2 minutes in verifyBGPPrefixesTelemetry to accommodate BGP prefix advertisement propagation.
  • Convergence Delay Adjustment: Extended the sleep duration in enableMultipath from 30 seconds to 60 seconds to ensure Arista EOS fully programs the ECMP FIB before validation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the wait times in the BGP multipath test by doubling the time.Sleep duration to 60 seconds after CLI configuration and extending the gnmi.Watch timeout to 2 minutes for prefix telemetry. Note that the use of time.Sleep violates the repository style guide, which recommends using gnmi.Watch with .Await for waiting on conditions. I have no feedback to provide.

@AmrNJ
Copy link
Copy Markdown
Contributor

AmrNJ commented Apr 7, 2026

/fptest hardware

Increase gnmi.Watch timeout in verifyBGPPrefixesTelemetry from 30s to
2 minutes to allow sufficient time for initial BGP prefix advertisement
over IS-IS loopback sessions to propagate to DUT telemetry.

Increase sleep in enableMultipath (Arista deviation path) from 30s to
60s to ensure EOS fully programs the 3-path ECMP FIB before traffic
validation begins, preventing transient packet loss during hardware
convergence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants