[RT-7.9] Update wait times for convergence#5310
[RT-7.9] Update wait times for convergence#5310yini101 wants to merge 1 commit intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts timing parameters within the BGP multipath test suite to improve stability. By increasing wait times for telemetry updates and hardware programming, the changes prevent race conditions and transient failures during network convergence. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5310 / e8b90beVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request increases the wait times in the BGP multipath test by doubling the time.Sleep duration to 60 seconds after CLI configuration and extending the gnmi.Watch timeout to 2 minutes for prefix telemetry. Note that the use of time.Sleep violates the repository style guide, which recommends using gnmi.Watch with .Await for waiting on conditions. I have no feedback to provide.
|
/fptest hardware |
Increase gnmi.Watch timeout in verifyBGPPrefixesTelemetry from 30s to 2 minutes to allow sufficient time for initial BGP prefix advertisement over IS-IS loopback sessions to propagate to DUT telemetry. Increase sleep in enableMultipath (Arista deviation path) from 30s to 60s to ensure EOS fully programs the 3-path ECMP FIB before traffic validation begins, preventing transient packet loss during hardware convergence.
Increase gnmi.Watch timeout in verifyBGPPrefixesTelemetry from 30s to 2 minutes to allow sufficient time for initial BGP prefix advertisement over IS-IS loopback sessions to propagate to DUT telemetry.
Increase sleep in enableMultipath (Arista deviation path) from 30s to 60s to ensure EOS fully programs the 3-path ECMP FIB before traffic validation begins, preventing transient packet loss during hardware convergence.