RELAY-1.1: DHCP Relay functionality

[ANISH-GOTTAPU]

Adding test for RELAY-1.1: DHCP Relay functionality

Readme Location: https://github.com/openconfig/featureprofiles/tree/main/feature/interface/helper_address/otg_tests/relay_agent_test

Logs for the test are added here :
https://partnerissuetracker.corp.google.com/issues/415458482#comment194

deviations used:
https://partnerissuetracker.corp.google.com/issues/497757203

[OpenConfigBot]

Pull Request Functional Test Report for #5303 / 94fb921

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RELAY-1.1: DHCP Relay functionality
Cisco 8000E		RELAY-1.1: DHCP Relay functionality
Cisco XRd		RELAY-1.1: DHCP Relay functionality
Juniper ncPTX		RELAY-1.1: DHCP Relay functionality
Nokia SR Linux		RELAY-1.1: DHCP Relay functionality
Openconfig Lemming		RELAY-1.1: DHCP Relay functionality

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RELAY-1.1: DHCP Relay functionality
Cisco 8808		RELAY-1.1: DHCP Relay functionality
Juniper PTX10008		RELAY-1.1: DHCP Relay functionality
Nokia 7250 IXR-10e		RELAY-1.1: DHCP Relay functionality

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive testing for DHCP Relay functionality within the feature profiles framework. It includes the necessary test logic to verify DHCPv4 and DHCPv6 address and gateway assignment, along with the required infrastructure to support vendor-specific configuration deviations for devices where standard OpenConfig paths for DHCP relay are not yet supported.

Highlights

• New Test Implementation: Added a new test suite for DHCP Relay functionality, covering both individual ports and LAG interfaces.
• Configuration Plugin: Introduced a new helper plugin to handle DHCP relay CLI configuration, specifically addressing vendor-specific requirements.
• Infrastructure Updates: Updated metadata and deviation definitions to support the new DHCP relay testing requirements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new DHCP relay agent test for both individual and LAG interfaces, along with a corresponding configuration plugin and a new deviation for unsupported OpenConfig DHCP relay paths. The review feedback identifies several issues: the DhcpRelayConfig plugin incorrectly applies CLI configuration directly instead of appending it to the provided gnmi.SetBatch as required by the repository style guide, and the new deviation accessor is missing a mandatory issue tracker link. Additionally, several instances of hardcoded interface and subinterface indices in the test code should be replaced with dynamic values from the test attributes for better maintainability.