Skip to content

[RT-5.12] Update the test to use mode instead of deprecated suppress#5300

Open
yini101 wants to merge 1 commit intoopenconfig:mainfrom
yini101:RT-5.12-deprecated-suppress
Open

[RT-5.12] Update the test to use mode instead of deprecated suppress#5300
yini101 wants to merge 1 commit intoopenconfig:mainfrom
yini101:RT-5.12-deprecated-suppress

Conversation

@yini101
Copy link
Copy Markdown
Contributor

@yini101 yini101 commented Apr 5, 2026

The path /interfaces/interface/subinterfaces/subinterface/ipv6/router-advertisement/config/suppress is deprecated in the openconfig/public models through openconfig/public#900. Instead, enable and mode is suppposed to be utilized in order to suppress RAs.

@yini101 yini101 requested a review from a team as a code owner April 5, 2026 06:23
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the IPv6 router advertisement test to align with recent changes in the OpenConfig public models. By replacing the deprecated 'suppress' configuration with the recommended 'enable' and 'mode' parameters, the test ensures compatibility with current standards while maintaining the expected functionality for suppressing router advertisements.

Highlights

  • Deprecation Update: Updated the router advertisement configuration to use 'Enable' and 'Mode' instead of the deprecated 'Suppress' path in accordance with OpenConfig model updates.
  • Test Configuration: Added a new platform exception for ARISTA devices to handle interface enablement deviations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IPv6 Router Advertisement suppression test by transitioning from the deprecated 'Suppress' leaf to the 'Mode' leaf and adding a platform exception for Arista. It also includes an explicit enablement of the IPv6 subinterface. Feedback was provided to ensure that the IPv6 interface enablement is performed conditionally based on the 'InterfaceEnabled' deviation, ensuring consistency with the existing IPv4 logic and preventing potential configuration issues on certain platforms.

@yini101 yini101 force-pushed the RT-5.12-deprecated-suppress branch from 29893ff to df86b46 Compare April 5, 2026 06:57
The path /interfaces/interface/subinterfaces/subinterface/ipv6/router-advertisement/config/suppress
is deprecated in the openconfig/public models through
openconfig/public#900. Instead, enable and mode
is suppposed to be utilized in order to suppress RAs.
@yini101 yini101 force-pushed the RT-5.12-deprecated-suppress branch from df86b46 to e9b66bb Compare April 10, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants