[RT-5.12] Update the test to use mode instead of deprecated suppress#5300
[RT-5.12] Update the test to use mode instead of deprecated suppress#5300yini101 wants to merge 1 commit intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the IPv6 router advertisement test to align with recent changes in the OpenConfig public models. By replacing the deprecated 'suppress' configuration with the recommended 'enable' and 'mode' parameters, the test ensures compatibility with current standards while maintaining the expected functionality for suppressing router advertisements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5300 / e9b66bbVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the IPv6 Router Advertisement suppression test by transitioning from the deprecated 'Suppress' leaf to the 'Mode' leaf and adding a platform exception for Arista. It also includes an explicit enablement of the IPv6 subinterface. Feedback was provided to ensure that the IPv6 interface enablement is performed conditionally based on the 'InterfaceEnabled' deviation, ensuring consistency with the existing IPv4 logic and preventing potential configuration issues on certain platforms.
29893ff to
df86b46
Compare
The path /interfaces/interface/subinterfaces/subinterface/ipv6/router-advertisement/config/suppress is deprecated in the openconfig/public models through openconfig/public#900. Instead, enable and mode is suppposed to be utilized in order to suppress RAs.
df86b46 to
e9b66bb
Compare
The path /interfaces/interface/subinterfaces/subinterface/ipv6/router-advertisement/config/suppress is deprecated in the openconfig/public models through openconfig/public#900. Instead, enable and mode is suppposed to be utilized in order to suppress RAs.