Add GenDA diffusion model with sensor conditioning#216
Draft
CodeVishal-17 wants to merge 2 commits intoopenclimatefix:mainfrom
Draft
Add GenDA diffusion model with sensor conditioning#216CodeVishal-17 wants to merge 2 commits intoopenclimatefix:mainfrom
CodeVishal-17 wants to merge 2 commits intoopenclimatefix:mainfrom
Conversation
Author
|
The failing pre-commit checks appear to come from existing Ruff/docstring violations in unrelated modules (aurora/cafa/anemoi) rather than the new GenDA implementation itself. The new GenDA test passes locally with: python -m pytest tests/test_genda.py Please let me know if you'd like me to additionally help clean up the existing lint/docstring issues. |
Collaborator
|
If you have time, cleaning up those ruff issues would be fantastic, but no worries if not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Implemented a new
GenDAdiffusion-based model with sensor conditioning support using the existing GenCast graph infrastructure.Changes made
Added
GenDAmodel implementation ingraph_weather/models/genda/Added sensor conditioning support using:
sensor_masksensor_valuesAdded classifier-free guidance style conditioning dropout during training
Added guided forward support for conditional inference
Integrated graph processing pipeline using existing GenCast graph builder and processor layers
Added tensor shape validation for conditioning inputs
Added package exports through
__init__.pyAdded unit test for forward-pass validation
Testing
A lightweight test configuration was used to validate:
Fixes #214
How Has This Been Tested?
Test command used:
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: