Skip to content

a lot of improvements (I hope)#44

Open
Mo-Gul wants to merge 26 commits into
openclimatedata:mainfrom
Mo-Gul:main
Open

a lot of improvements (I hope)#44
Mo-Gul wants to merge 26 commits into
openclimatedata:mainfrom
Mo-Gul:main

Conversation

@Mo-Gul

@Mo-Gul Mo-Gul commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

feel free to cherry-pick

@rgieseke

Copy link
Copy Markdown
Contributor

Good catches!

@Mo-Gul

Mo-Gul commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

Any ideas what is missing for a merge?

@rgieseke

Copy link
Copy Markdown
Contributor

Any ideas what is missing for a merge?

Time and motivation to review :/

It's a very big one and it mixes fixing obvious mistakes, stylistic issues and conceptual changes. It would be much easier to review if you had started with a smaller PR and if they were scoped thematically.

There are also changes that might relate to differences between bibtex, biblatex, ... and I'm not actually not sure what level of compatibility we aim for.

@Mo-Gul

Mo-Gul commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

You are right, most likely it would have been better to split it into some smaller PRs, but I had a "run" ;)
Most likely it is simplest to just click through the single commits to verify that the LOG message delivers what it promises.

@rgieseke

Copy link
Copy Markdown
Contributor

I cherry-picked the first commits in #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants