fix: preserve quoted replies in text sends#302
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 13, 2026, 6:26 PM ET / 22:26 UTC. Summary Reproducibility: yes. The linked issue provides a concrete direct-message and IPC reproduction, and current-main source shows that reply context lacks QuotedMessage; this review did not independently run a live WhatsApp account. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the focused implementation after normal exact-head maintainer review so stored targets render complete quotes while the documented unsynced group fallback remains compatible. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue provides a concrete direct-message and IPC reproduction, and current-main source shows that reply context lacks QuotedMessage; this review did not independently run a live WhatsApp account. Is this the best way to solve the issue? Yes. Building complete context from stored messages while preserving the explicit unsynced-group fallback is the narrowest compatible correction, and the current head adds focused coverage for both paths. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b1eb33538df3. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles)
|
|
🦞🧹
This is fix-only; I will not merge this PR. Re-review progress:
|
|
🦞✅ Source: No actionable findings remain. I removed the repair-loop label and left the PR open for maintainer review and merge. Automerge progress:
|
Summary
Why
send text --reply-tocurrently emits only a stanza ID and optional participant. WhatsApp accepts and delivers the message but can omit the recipient-side quote box becauseQuotedMessageis absent. Direct-message lookups can also miss silently and still report a successful send.Validation
Closes #301
Thanks @odilorg for the detailed report and live reproduction evidence.