fix(ci): resolve the default branch before the ancestry check - #277
Merged
Conversation
The release job checks out the tag, so no remote-tracking ref for the default branch exists, and the guard fetched it with --depth=1 into FETCH_HEAD only. git merge-base --is-ancestor then failed on a commit that is plainly on main, blocking v0.13.0 publication after the native gate had already passed. Fetch the branch into refs/remotes/origin/<branch> with full history, which is what the ancestry question actually needs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.13.0 release reached npm publication and failed the tag guard:
The commit is plainly on
main— the guard couldn't see it. Two compounding causes in one line:ref: <tag>, sorefs/remotes/origin/mainnever exists in that checkout.git fetch --no-tags origin "$DEFAULT_BRANCH" --depth=1, which lands inFETCH_HEADwithout creating the tracking ref — and a depth-1 fetch could not answer an ancestry question even if the ref did exist.Now fetched as
+refs/heads/<branch>:refs/remotes/origin/<branch>with full history, which is whatgit merge-base --is-ancestoractually requires.The guard behaved correctly in the sense that mattered: it failed before publication, so nothing was half-released — npm is still on 0.12.4 and the published GitHub Release with its verified assets is untouched. Per
docs/RELEASE.md, recovery is a manual Release dispatch with the same tag, which repeats every tag, main, native-proof, source-gate, npm and Homebrew check.Verified with
actionlint(clean).🤖 Generated with Claude Code