test: synchronize process timeout fixture - #204
Merged
Conversation
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: test: synchronize process timeout fixture This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The descendant-cleanup regression started its 500 ms kill deadline immediately after launching its shell fixture, then read the PID file only after the timed operation returned. Under scheduler pressure, the timeout could terminate the shell before it spawned the child and wrote
pids, producing NSCocoaErrorDomain 260. The temporary directory cleanup was not early; the file had never been created.Fix
ProcessTimeoutowner testsProof
imsg --versionreturned 0.13.5 andimsg status --jsonreturned a valid SIP-safe payload