fix: retire automatic live proof - #1280
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 28, 2026, 9:23 AM ET / 13:23 UTC. ClawSweeper reviewWhat this changesThe PR removes automatic live-proof planning and execution from exact and scheduled reviews, preserves historical proof-artifact publication, and hides legacy batch journeys from Bay’s default view. Merge readinessNo introduced correctness or security defect surfaced, and the current-head local Worker proof is strong. This PR remains necessary because retiring automatic execution is an intentional workflow-policy decision that needs maintainer confirmation before merge. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: PASS (completed) Assertions:
How this fits togetherClawSweeper’s review workflows create artifacts that are published directly or through the queue, while Bay renders their public read-only status. This change removes new proof execution from those workflows but retains historical artifact handling and exposes legacy-path status only as an observer toggle. flowchart LR
A[Review request] --> B[Review workflow]
B --> C[Review artifact]
C --> D[Direct or legacy publication]
D --> E[Public review result]
D --> F[Bay status projection]
G[Historical proof artifacts] --> D
Decision needed
Why: The patch is technically coherent, but it deliberately removes an existing review capability and changes the operational proof model; implementation evidence cannot establish that policy preference. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm the retirement direction, then retain contributor-supplied proof and historical-artifact compatibility while using direct review publication as the normal path. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a deliberate retirement rather than a reported defect. The supplied current-head proof instead exercises the changed workflow contracts and local Worker projection. Is this the best way to solve the issue? Unclear: the implementation and compatibility coverage support the proposed path, but whether automatic execution should be retired is a maintainer policy decision. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a4592a03e194. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (7 earlier review cycles)
|
86d7fe2 to
5ea2bdf
Compare
5ea2bdf to
ee2596e
Compare
ee2596e to
ceb93f3
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Stop automatic live-proof execution, restore direct review publication, retain historical artifact compatibility, and separate retired proof/batch journeys from the default OpenClaw Bay view. Worked on by: - @brokemac79 Co-authored-by: brokemac79 <255583030+brokemac79@users.noreply.github.com>
ceb93f3 to
aeccb97
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Remove the orphaned generator and one-shot fixture after automatic live-proof planning was retired in #1280. Keep historical artifact compatibility and low-level drivers unchanged.
Summary
Initial value analysis: why retire it
The automatic live-proof lane was not adding enough independent review value to justify its cost and failure surface:
The narrow conclusion was to remove new automatic planning/execution, restore direct publication as the default, and retain historical compatibility while those artifacts age out.
PR behavior proof
ExactReviewQueue,/api/status, and/bay.docs/proof/retire-automatic-live-proof/run-proof.shin Crabboxlocal-containeron current headaeccb97a2fac48a3cf270fcb90d4df84b6dedf5band basea4592a03e194228fc66b57bc4ad64deb11fb444b; runrun_9eebd46fa0b5, leasecbx_49823050dad7, Podman runtime,node:24-bookwormimage.docs/proof/retire-automatic-live-proof/receipt.json, the behavior contract and proof script, plus the redacted readable transcript below.Validation and reviews
pnpm run checkon Node 26: 3,967 passed, 0 failed, 0 cancelled, 8 skipped; formatting, static checks, builds, lint, and coverage thresholds passed.origin/main: no actionable correctness issues.--local-rangereview on the exact base/head: patch correct, no findings or security concerns, proof sufficient, no rank-up moves.Readable current-head proof transcript
aeccb97a2fac48a3cf270fcb90d4df84b6dedf5ba4592a03e194228fc66b57bc4ad64deb11fb444blocal-container, runrun_9eebd46fa0b5, leasecbx_49823050dad7, Podman,node:24-bookwormbash docs/proof/retire-automatic-live-proof/run-proof.shSanitized stderr contained only package-manager/bootstrap notices and the three TypeScript build commands; it contained no runtime or assertion error. Crabbox returned exit 0. Independent cleanup checks found no matching lease or container after the known Podman rootless-network cleanup warning.
Maintainer direction
The originating human request explicitly chose full retirement of automatic ClawSweeper live-proof generation and execution, with no replacement proof lane. Contributor- and maintainer-supplied proof remains part of ordinary review readiness.
Review finding disposition
OpenClaw Bay
Affected and updated. Bay remains public, indexable, and observer-only; the comparison switch changes presentation only and cannot trigger queue, workflow, GitHub, recovery, deploy, or rollback actions.
Worked on by