Skip to content

fix(runner): cap HuggingFace Retry-After backoff at 30s #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebTardif wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

fix(runner): cap HuggingFace Retry-After backoff at 30s #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/runner/benchmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,11 +929,11 @@ func isRetriableHuggingFaceRowsStatus(statusCode int) bool {
func huggingFaceRowsBackoff(attempt int, headers http.Header) time.Duration {
if retryAfter := headers.Get("Retry-After"); retryAfter != "" {
if seconds, err := strconv.Atoi(retryAfter); err == nil && seconds >= 0 {
return time.Duration(seconds) * time.Second
return min(time.Duration(seconds)*time.Second, 30*time.Second)
}
if retryAt, err := http.ParseTime(retryAfter); err == nil {
if delay := time.Until(retryAt); delay > 0 {
return delay
return min(delay, 30*time.Second)
}
}
}
Expand Down
13 changes: 13 additions & 0 deletions internal/runner/submission_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,19 @@ func TestHuggingFaceBenchmarkClientHonorsCancelDuringRetryBackoff(t *testing.T)
}
}

func TestHuggingFaceRowsBackoffCapsRetryAfter(t *testing.T) {
got := huggingFaceRowsBackoff(1, http.Header{"Retry-After": []string{"3600"}})
if got != 30*time.Second {
t.Fatalf("Retry-After 3600 = %s, want 30s", got)
}

future := time.Now().UTC().Add(2 * time.Hour).Format(http.TimeFormat)
got = huggingFaceRowsBackoff(1, http.Header{"Retry-After": []string{future}})
if got != 30*time.Second {
t.Fatalf("Retry-After HTTP-date %q = %s, want 30s", future, got)
}
}

func withHuggingFaceRowsRetryDelay(t *testing.T, delay time.Duration) {
t.Helper()
previous := huggingFaceRowsRetryDelay
Expand Down
Loading