Skip to content

Allow only custom actions in ACL #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtneug wants to merge 1 commit into
base: r/19.x
Choose a base branch
from
+5 −2
Open

Allow only custom actions in ACL #1606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/slices/aclSlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,11 @@ export const checkAcls = (acls: TransformedAcl[]) => (dispatch: AppDispatch, get
bothRights = true;
}

// check if each policy has read or write right (at least one checkbox should be checked)
if (!acls[i].read && !acls[i].write) {
// check if each policy has either
// - read rights
// - write rights
// - custom action rights
if (!acls[i].read && !acls[i].write && acls[i].actions.length === 0) {
check = false;
}
}
Expand Down
Loading