Skip to content

Python version update#226

Open
andamian wants to merge 12 commits into
opencadc:mainfrom
andamian:python-update
Open

Python version update#226
andamian wants to merge 12 commits into
opencadc:mainfrom
andamian:python-update

Conversation

@andamian

@andamian andamian commented May 26, 2026

Copy link
Copy Markdown
Contributor

Updated the supported Python versions (3.10-3.14).
Fix a few issues: #60, #224, #208, #164
Also took advantage to replace the use of golden files in testing the CLI parsers eliminating the annoying formatting dependency on argparse

Adrian Damian and others added 2 commits May 26, 2026 16:13
Drop EOL Python 3.9 from tox and CI, add 3.14, tighten python_requires
and trove classifiers, and bump cadcutils/cadcdata/cadctap versions for PyPI.

Co-authored-by: Cursor <cursoragent@cursor.com>
The scratch scripts are no longer under package test directories.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.36585% with 30 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@5c2bf56). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cadctap/cadctap/core.py 82.35% 9 Missing ⚠️
cadcutils/cadcutils/util/cli_errors.py 69.56% 7 Missing ⚠️
cadcutils/cadcutils/net/ssl_errors.py 91.22% 5 Missing ⚠️
cadcutils/cadcutils/net/auth.py 75.00% 3 Missing ⚠️
cadcutils/cadcutils/net/groups_client.py 25.00% 3 Missing ⚠️
cadcutils/cadcutils/net/ws.py 80.00% 2 Missing ⚠️
cadcutils/cadcutils/old_get_cert.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage        ?   87.18%           
=======================================
  Files           ?       29           
  Lines           ?     3323           
  Branches        ?        0           
=======================================
  Hits            ?     2897           
  Misses          ?      426           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adrian Damian and others added 8 commits May 28, 2026 15:26
cadc-get-cert issues proxy certificates, so offering --cert for
authentication was redundant. Build its CLI with usecert=False,
harden Subject.from_cmd_line_args, and update help fixtures and tests.

Also ignore coverage.xml in .gitignore.

Co-authored-by: Cursor <cursoragent@cursor.com>
@andamian andamian requested a review from shinybrar June 2, 2026 19:46

@shinybrar shinybrar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andamian
While in general this PR looks good, I think we should not go down the route of create / maintaining custom core logic, especially to power the help sections for our CLI Applications.

Look into,

This could be a path that might require a lot of work for us down the road.

@andamian

andamian commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@andamian While in general this PR looks good, I think we should not go down the route of create / maintaining custom core logic, especially to power the help sections for our CLI Applications.

Look into,

This could be a path that might require a lot of work for us down the road.

@shinybrar - yes, but that's outside the scope of this PR. That part works in general and changing it is not a priority, at least for the existing apps. I've only updated the tests to remove the dependency on argparse's formatting which kept breaking the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants