Skip to content

PlannedMultiMapFixed: match SetScale - #200

Open
GeneralAtrox wants to merge 1 commit into
openblack:mainfrom
GeneralAtrox:plannedmultimapfixed-setscale
Open

PlannedMultiMapFixed: match SetScale#200
GeneralAtrox wants to merge 1 commit into
openblack:mainfrom
GeneralAtrox:plannedmultimapfixed-setscale

Conversation

@GeneralAtrox

Copy link
Copy Markdown
Contributor

PlannedMultiMapFixed::SetScale

Matches PlannedMultiMapFixed::SetScale(float) byte-for-byte on all three versions (BW1W100 / BW1W110 / BW1W120).

Changes

  • src/Black/Abode.cpp — implement the body (this->scale = scale;)
  • config/BW1W100/symbols.txt & config/BW1W110/symbols.txt — name the vfunc73 slot as SetScale (BW1W120 already names it)

Verification

objdiff-cli reports 100% on every version. Identical instruction stream, original split vs compiled source:

mov eax, [esp+0x4]
mov [ecx+0x2c], eax
ret 0x4
Version Match
BW1W100 100%
BW1W110 100%
BW1W120 100%

SetScale is unfolded (its own unique address in all three), so the per-object match is conclusive.

🤖 Generated with Claude Code

Names the vfunc73 vtable slot as SetScale in BW1W100 and BW1W110
(BW1W120 already names it) and implements the body. Byte-identical
on all three versions (objdiff 100%).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@decomp-dev

decomp-dev Bot commented Jun 30, 2026

Copy link
Copy Markdown

Report for BW1W100 (18d9e27 - c3c7bd5)

📈 Matched code: 0.80% (+0.00%, +10 bytes)

✅ 1 new match
Unit Item Bytes Before After
runblack-decrypted/Black/Abode public: virtual void __thiscall PlannedMultiMapFixed::SetScale(float) +10 0.00% 100.00%

Report for BW1W110 (18d9e27 - c3c7bd5)

📈 Matched code: 0.84% (+0.00%, +10 bytes)

✅ 1 new match
Unit Item Bytes Before After
runblack-decrypted/Black/Abode public: virtual void __thiscall PlannedMultiMapFixed::SetScale(float) +10 0.00% 100.00%

Report for BW1W120 (18d9e27 - c3c7bd5)

📈 Matched code: 0.91% (+0.00%, +10 bytes)

✅ 1 new match
Unit Item Bytes Before After
runblack-decrypted/Black/Abode public: virtual void __thiscall PlannedMultiMapFixed::SetScale(float) +10 0.00% 100.00%

Comment thread src/Black/Abode.cpp
{
this->scale = scale;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. There shouldn't be any PlannedMultiMapFixed definitions in Abode.cpp.
Most likely this was inlined PlannedMultiMapFixed.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants