PlannedMultiMapFixed: match SetScale - #200
Open
GeneralAtrox wants to merge 1 commit into
Open
Conversation
Names the vfunc73 vtable slot as SetScale in BW1W100 and BW1W110 (BW1W120 already names it) and implements the body. Byte-identical on all three versions (objdiff 100%). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Report for BW1W100 (18d9e27 - c3c7bd5)📈 Matched code: 0.80% (+0.00%, +10 bytes) ✅ 1 new match
Report for BW1W110 (18d9e27 - c3c7bd5)📈 Matched code: 0.84% (+0.00%, +10 bytes) ✅ 1 new match
Report for BW1W120 (18d9e27 - c3c7bd5)📈 Matched code: 0.91% (+0.00%, +10 bytes) ✅ 1 new match
|
bwrsandman
requested changes
Jun 30, 2026
| { | ||
| this->scale = scale; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This is wrong. There shouldn't be any PlannedMultiMapFixed definitions in Abode.cpp.
Most likely this was inlined PlannedMultiMapFixed.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlannedMultiMapFixed::SetScale
Matches
PlannedMultiMapFixed::SetScale(float)byte-for-byte on all three versions (BW1W100 / BW1W110 / BW1W120).Changes
src/Black/Abode.cpp— implement the body (this->scale = scale;)config/BW1W100/symbols.txt&config/BW1W110/symbols.txt— name thevfunc73slot asSetScale(BW1W120 already names it)Verification
objdiff-clireports 100% on every version. Identical instruction stream, original split vs compiled source:SetScaleis unfolded (its own unique address in all three), so the per-object match is conclusive.🤖 Generated with Claude Code