feat(okms): add okms plugin#88
Open
Sakutaroo wants to merge 2 commits into
Open
Conversation
Signed-off-by: Kevin Demy <kevin.demy@ovhcloud.com>
satoqz
reviewed
May 6, 2026
satoqz
left a comment
satoqz
left a comment
Member
There was a problem hiding this comment.
I wonder if in this case we'd want to place it at kms/ovh, so we'd get kms-ovh instead of kms-okms which is clearer and has no duplication. This mirrors other simplifications we've made to plugin names opposed to wrapper names, see #75.
LGTM otherwise.
Member
|
Seems like you need to run another |
Signed-off-by: Kevin Demy <kevin.demy@ovhcloud.com>
Author
Yes, I think that until the wrapper PR is merged (openbao/go-kms-wrapping#89), there will be issues with go mod tidy. I will update this PR once the wrapper is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OVHcloud KMS wrapper plugin
This feature implements a new KMS plugin. It is based on the wrapper implementation from openbao/go-kms-wrapping#89 and follows the same pattern as existing KMS plugins.