Skip to content

build(deps): secure Dokka Jackson classpath #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbeckwith-oai wants to merge 1 commit into
base: codex/update-dokka
Choose a base branch
from
+20 −1
Open

build(deps): secure Dokka Jackson classpath #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,30 @@ plugins {
id("org.jetbrains.dokka") version "2.1.0"
}

val dokkaJacksonVersion = "2.18.9"

repositories {
mavenCentral()
}

allprojects {
group = "com.openai"
version = "4.43.0" // x-release-please-version

// Dokka 2.1.0 depends on Jackson 2.15.3. Keep its isolated build-tool classpaths on a
// secure, internally aligned Jackson release without changing the SDK's published or
// compatibility-test dependency versions.
configurations.matching { it.name.startsWith("dokka") }.configureEach {
resolutionStrategy.eachDependency {
if (
requested.group == "com.fasterxml.jackson" ||
requested.group.startsWith("com.fasterxml.jackson.")
) {
useVersion(dokkaJacksonVersion)
because("Dokka's build-only Jackson classpath must use a secure aligned release")
}
}
}
}

subprojects {
Expand Down
4 changes: 3 additions & 1 deletion openai-java-core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ val jacksonPublishedRuntime by configurations.creating {
isCanBeResolved = true
}

configurations.matching { it.name != jacksonPublishedRuntime.name }.configureEach {
configurations.matching {
it.name != jacksonPublishedRuntime.name && !it.name.startsWith("dokka")
}.configureEach {
resolutionStrategy {
// Compile and test against a lower Jackson version to ensure we're compatible with it. Note that
// we generally support 2.13.4, but test against 2.14.0 because 2.13.4 has some annoying (but
Expand Down
Loading