fix(deps): update test Handlebars to 4.5.3#783
Open
jbeckwith-oai wants to merge 1 commit into
Open
Conversation
ba16b44 to
9e5437a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version choice
Handlebars 4.5.2 is the first release containing the FileTemplateLoader path-traversal fix. This uses 4.5.3 because it also includes the follow-on SpringTemplateLoader arbitrary-file-read fix.
handlebars-helpers intentionally remains at WireMock's requested 4.3.1. WireMock 2.35.2 links helper classes under com.github.jknack.handlebars.helper, while helpers 4.5.3 moved those classes to a different package; aligning both artifacts breaks response templating with NoClassDefFoundError. The vulnerable artifact is Handlebars core, and the new integration test proves the narrow mixed-version graph preserves WireMock's template behavior.
Compatibility
This change affects test configurations only. Handlebars and WireMock are absent from the generated Maven POMs and Gradle module metadata. Published SDK classes remain Java 8 bytecode (class-file major version 52), and no public API, runtime dependency, or Jackson compatibility floor changes. Handlebars 4.5.3 itself requires Java 17, but it runs only in this repository's JDK 21 test toolchain and is never exposed to consumers.
Validation
Addresses https://github.com/openai/openai-java/security/dependabot/91