fix: use tuple form for SpeechGroupSpanData __slots__#3534
Merged
Conversation
__slots__ was assigned the bare string "input", which Python treats as
an iterable of single characters, creating slots i, n, p, u, t instead
of a single input slot. Every other SpanData subclass uses tuple form;
align this one to ("input",).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpeechGroupSpanData.__slots__is assigned a bare string"input"instead of a one-element tuple. Because Python treats a string as an iterable, this creates five single-character slots (i,n,p,u,t) rather than a singleinputslot — so the class does not get the intended__slots__for its actual attribute.Every other
SpanDatasubclass in this file already uses the tuple form (e.g.("input", "output", "usage")), so this alignsSpeechGroupSpanDatawith the rest and ensuresself.inputis backed by a real slot.Checks
ruff check src/agents/tracing/span_data.py— passesruff format --check src/agents/tracing/span_data.py— already formatted