Skip to content

Add zypper keys command#163

Open
bzeller wants to merge 1 commit into
openSUSE:masterfrom
bzeller:keylist_cmd
Open

Add zypper keys command#163
bzeller wants to merge 1 commit into
openSUSE:masterfrom
bzeller:keylist_cmd

Conversation

@bzeller

@bzeller bzeller commented Mar 14, 2018

Copy link
Copy Markdown
Contributor

Adds a zypper trusted key management API that allows the user to list/add/remove keys from the trusted keys database in zypper.

@bzeller bzeller force-pushed the keylist_cmd branch 3 times, most recently from ea5f89b to f26dd28 Compare March 15, 2018 09:59
@mlandres

Copy link
Copy Markdown
Member

A good start. 2 things immediately caught my eye:

  1. The commands probably don't need to launch the repos (refresh and loading the repo data). Initializing the Target should be enough.
  2. (nit-picky) The term subcommand is used for external programs just hooked into zypper (zypper help subcommand). zypper keys will become a (builtin) command :)

@bzeller bzeller force-pushed the keylist_cmd branch 3 times, most recently from 2dfb38d to 459c266 Compare March 16, 2018 15:49
@bzeller bzeller changed the title [WIP] Add zypper keys subcommand Add zypper keys subcommand Mar 16, 2018
Comment thread src/keys.cc
Comment thread src/keys.cc
Comment thread src/callbacks/keyring.h Outdated
Comment thread src/Zypper.cc Outdated
Comment thread src/Zypper.cc Outdated
Comment thread src/Zypper.cc Outdated
@bzeller bzeller force-pushed the keylist_cmd branch 2 times, most recently from 2b91475 to 284750f Compare January 14, 2019 08:56
@bzeller bzeller changed the title Add zypper keys subcommand Add zypper keys command Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants