Skip to content

Initialize OAuth2 default endpoints and expose WorkflowDefinitionId separator#1551

Open
ricardozanini wants to merge 1 commit into
open-workflow-specification:mainfrom
ricardozanini:oauth2-defaults-and-separator
Open

Initialize OAuth2 default endpoints and expose WorkflowDefinitionId separator#1551
ricardozanini wants to merge 1 commit into
open-workflow-specification:mainfrom
ricardozanini:oauth2-defaults-and-separator

Conversation

@ricardozanini

Copy link
Copy Markdown
Collaborator

Summary

  • Initialize OAuth2AuthenticationPropertiesEndpoints in OIDCBuilder constructor so OAuth2 objects created via the fluent API have spec-compliant default endpoints (/oauth2/token, /oauth2/revoke, /oauth2/introspect) instead of null
  • Add DEFAULT_SEPARATOR constant (:) to WorkflowDefinitionId and use it in toString(), so downstream projects (e.g. quarkus-flow) can reference the canonical separator without duplicating it

Test plan

  • All 162 tests in fluent/spec and impl/core pass
  • Verify OAuth2 endpoints are non-null when building via fluent API
  • Verify WorkflowDefinitionId.DEFAULT_SEPARATOR is accessible from downstream

@ricardozanini
ricardozanini requested a review from fjtirado as a code owner July 20, 2026 20:17
…eparator

- Initialize OAuth2AuthenticationPropertiesEndpoints in OIDCBuilder
  so OAuth2 objects have spec-compliant default endpoints
  (/oauth2/token, /oauth2/revoke, /oauth2/introspect) instead of null
- Add DEFAULT_SEPARATOR constant to WorkflowDefinitionId and use it
  in toString()

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini
ricardozanini force-pushed the oauth2-defaults-and-separator branch from 811352a to b7557fe Compare July 20, 2026 20:18
@fjtirado

Copy link
Copy Markdown
Collaborator

@ricardozanini I cannot merge till you sign the PR (yes, its something new needed after repo move that can be configured in the IDE in 5 minutes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants